27881 - From: not populated when 1st account selected

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[esther]

Using builds 2000-02-15-10 on win98 and linux and 2000-02-15-09 on Mac the From: 
addressing field is not expanded horizonally and populated when user has 
selected the 1st account of a profile that contains 2 or more accounts.

1. Launch Messenger  (with a profile that has 2 mail accounts)
2. Select the Inbox of the 1st account (give password if needed) and click the 
New Msg button.  
Notice the From field is just a drop-down button.
3. Close New Msg window 
4. Select the 2nd mail account (give password if necessary),  click on the New 
Msg button.
Notice the From field has the selected account as the From: 
Note: The outgoing server in this case was the same as the 1st account server.

Comment 1

[Richard Zach]

*** Bug 27649 has been marked as a duplicate of this bug. ***

Comment 2

[Richard Zach]

As reported in the bug I just duplicated:

1. The From line is not set, regardless of what account is selected, if you
Reply, Reply All, or Forward.

2. The message is not sent, and no error message is displayed.  That makes this
bug pretty bad, since it means messages are getting lost.  Marking dogfood.

Comment 3

[Richard Zach]

Sorry, I take that back.  Message did get sent. It just took a long time for the
messages to arrive.

Comment 4

[Phil Peterson]

Nominate for beta1

Comment 5

[leger]

Putting on PDT+ radar for beta1.

Comment 6

[leger]

Putting on PDT+ radar for beta1.

Comment 7

[lchiang]

since this is PDT+, I'll set the target milestone from blank to M14.

Comment 8

[Jean-Francois Ducarroz]

cc'ing rods as it's a problem with dropdown list

Comment 9

[Jean-Francois Ducarroz]

I've just checked that I was correctly setting the From select element with the 
correct items, there are ok. If I add an extrat dummy item (option) at the 
beginning of the select element, then everything is works fine. Looks like it's 
a problem when you set the select.value to the first item. Reassign to rods

Comment 10

[rods (gone)]

The only problem I am seeing (other than the crash when I tried to get my home 
e-mail from my pop account) is the combobox doesn't show the correct value for 
my work imail account in the "From" field (the first account), in fact it is 
only a few pixels wider tthan the dropdown btn. 

When I switch to the second account and hit new message the "From" field lokks 
perfect.

I'll take a look at why the combobox is displaying any value even though 
there are at least two in the list.

Comment 11

[rods (gone)]

For some reason the comboxbox isn't getting reflowed because block reflow 
doesn't think it is dirty and needs to be reflowed. Should be easy to fix, but I 
need to consult with buster.

Comment 12

[rods (gone)]

Ok, so it wasn't easy. I have had to rework Combobox reflow, which it really 
needed, and I am still testing. I get a warning out of reflow that I need to get 
rid of.

Comment 13

[Richard Zach]

*** Bug 28411 has been marked as a duplicate of this bug. ***

Comment 14

[Richard Zach]

*** Bug 28755 has been marked as a duplicate of this bug. ***

Comment 15

[Richard Zach]

*** Bug 28794 has been marked as a duplicate of this bug. ***

Comment 16

[esther]

This bug, as originally stated, was specific about the From: not being 
expanded for a NEW MSG on the 1st account only, (Reply, Reply To: or Forward 
msg was not part of this bug, the short description had been changed to include 
Reply).  As "rods" pointed out in his comment dated 2-17-2000 he is only seeing 
the problem in the 1st account when doing a NEW MSG.  The behavior is different 
when user is doing a Reply, Reply To or Forward (the From doesn't expand no 
matter which account you have selected a message in and is what duplicate bug 
27649 states).  Two bugs have been combined to one.  "rods" if this should be 2 
different bugs, please let me know and I will separate them.  If not, QA Note 
this should be tested to include New Msg, Reply, Reply To and Forward.  

Comment 17

[rods (gone)]

The new rewrite of combobox reflow provides a 3x improvement in CPU time usage 
for laying out pages with several controls.

Comment 18

[Richard Zach]

If you want a separate bug for the case of Reply and Forward, you can reopen bug
27649.

Comment 19

[leger]

Need ETA on fix for this in Status Whiteboard please.

Comment 20

[rods (gone)]

Still testing the rewrite

Comment 21

[Richard Zach]

This looks like it's working for me on Linux build 2000.02.025.08; maybe fixed
along with bug 28460?

Comment 22

[rods (gone)]

This got fixed by a box layout fix, but I have rewritten the reflow for the 
combobox for performance.

Comment 23

[Richard Zach]

Should we close this bug then?

Comment 24

[esther]

Using build 2000-02-28-09 on Win98 and 2000-02-28-08 on Mac, New Msg, Reply, 
Reply All, Forward all populate the From field with the selected account.  
Tested with 2 accounts, each one selected as I ran through the various Compose 
windows.   Note: Linux testing done by zach, Rod please Resolve this as fixed 
and I will verify.

Comment 25

[rods (gone)]

No, I don't want to close it until I get the new code checked in.

Comment 26

[rods (gone)]

updated status

Comment 27

[rods (gone)]

Fixed

Comment 28

[Richard Zach]

*** Bug 30063 has been marked as a duplicate of this bug. ***

Comment 29

[esther]

Using win32 commercial build 2000-03-06-14, mac mozilla build 2000-03-06-08 and 
linux mozilla build 2000-03-06-13 this is fixed. I tried New Msg, 
Reply, Reply to All and Forward with the 1st account and then again 
with the 2nd account, From field was correct. Verified.