281133 - Adding a page to bookmarks fails when the page has no <title>

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Simon Fraser [no longer active]]

If I try to bookmark a text file or somesuch, the Add Bookmark dialog throws an
error:

2005-02-04 17:10:43.234 Camino[6819] *** Assertion failure in -[NSTextFieldCell
_objectValue:forString:], AppKit.subproj/NSCell.m:1131

2005-02-04 17:10:43.335 Camino[6819] Invalid parameter not satisfying: aString
!= nil

and never comes up.

Comment 1

[Mike Pinkerton (not reading bugmail)]

whooops!

Comment 2

[Simon Fraser [no longer active]]

Should I use the url to fill the text box, or use "untitled"? I'd rather not
leave it empty, because that dialog has no code to disable the OK button when
the text field is empty.

Comment 3

[Mike Pinkerton (not reading bugmail)]

i can go either way, honestly. "untitled" might be good, but what's more useful
in the menu if they don't change it?

Comment 4

[Simon Fraser [no longer active]]

*** Bug 282147 has been marked as a duplicate of this bug. ***

Comment 5

[Simon Fraser [no longer active]]

Fix checked in; I use the url if the title is empty.

Comment 6

[Wevah (Nate Weaver)]

Ugh, this looks like it's broken again. I'm getting a bunch of

2005-04-02 05:45:46.085 Camino[23634] *** Assertion failure in -[NSTextFieldCell
_objectValue:forString:], AppKit.subproj/NSCell.m:1079
2005-04-02 05:45:46.088 Camino[23634] Invalid parameter not satisfying: aString
!= nil

on pages with no <title>. Reopening.

Comment 7

[Wevah (Nate Weaver)]

It's happening in -[AddBookmarkDialogController
showDialogWithLocationsAndTitles:isFolder:onWindow:], FWIW.

Comment 8

[Simon Fraser [no longer active]]

Fixed again.