Closed Bug 281499 Opened 19 years ago Closed 19 years ago

Move perl-version-checking into a module

Categories

(Bugzilla :: Bugzilla-General, enhancement)

2.19.2
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mkanat, Assigned: mkanat)

Details

Attachments

(1 file, 1 obsolete file)

This is a tiny, tiny little part of bug 281494, just to get the initial
structure established.

Basically, this creates the Requirements module, and the Requirements module
requires the correct version of perl. It will also eventually contain a LOT of
functions that are now in checksetup's BEGIN block.
Summary: Move perl-version-checking into a subroutine in a module → Move perl-version-checking into a module
Attached patch Create Bugzilla::Requirements (obsolete) — Splinter Review
OK, here it is! :-) As soon as we get this in, I can do more work on checksetup
in this direction.

This is just the *absolute* most tiny change that I can make, just to put this
structure in place.
Attachment #173732 - Flags: review?
Glob pointed out that we really need to do any version checking before we ever
"use" anything -- what if people are using perl 5.0?
Attachment #173732 - Attachment is obsolete: true
Attachment #173733 - Flags: review?
Attachment #173732 - Flags: review?
Actually, this is really too small of a change, and I don't think it's worth it.
I'll start the creation of Requirements.pm from some other code change. But I'll
use some of the stuff that I wrote here as a base.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
Comment on attachment 173733 [details] [diff] [review]
Version 2 (use -p1)

As you marked this bug as wontfix, I guess I can remove your request for
review. :)
Attachment #173733 - Flags: review?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: