281632 - Add javascript to focus/select the voting textbox or checkbox

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[GavinS]

Bug 250440 tried this once, and failed. Try again...

Comment 1

[GavinS]

Attachment: try adding javascript to focus the voting form

1 question: is this OK in the case when we are just viewing the list, and not
voting for a specific bug? (In that case we just try and focus a non-existent
form control)

Comment 2

[GavinS]

Attachment: add javascript to focus voting textbox or checkbox

This version removes the javascript error by only attempting the focus when we
are actually voting

Comment 3

[Marc Schumann [:Wurblzap]]

Comment on attachment 174128 [details] [diff] [review]
add javascript to focus voting textbox or checkbox

>+    [% IF bug_id %]
>+      [%# We .select and .focus the input so it works for textbox and 
>+          checkbox %]
>+      [% onload = "document.forms['voting_form'].bug_" _ bug_id _
>+                  ".select();document.forms['voting_form'].bug_" _ bug_id _
>+                  ".focus()" %]
>+      [% END %]

The [% END %] is misaligned. Please update on a new patch, and set r+ on it.
The patch is good otherwise. I'm fine with having select as well as focus, good
thing you commented that.

Comment 4

[GavinS]

Attachment: add javascript to focus voting textbox or checkbox v3

fix indentation and carry over Marc's r+

Comment 5

[Shane H. W. Travis]

Checking in template/en/default/bug/votes/list-for-user.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/list-for-
user.html.tmpl,v  <--  list-for-user.html.tmpl
new revision: 1.19; previous revision: 1.18
done