282184 - sync xpfe menu.xml with toolkit menu.xml

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[Mike Connor [:mconnor]]

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: 2005.03.08 X2T diff report

Diff from Xpfe to Toolkit version.

These came from Toolkit versions
{{
1.8	mozilla.mano%sent.com	2005-02-20 07:49		Bug 221824 -
Winstripe should be RTL compatible. patch by kmgerich and me r=kmgerich/mconnor

1.5	bsmedberg%covad.net	2004-10-02 18:19		Bug 221824,
part 2, add content hooks for submenu expander and back/forward buttons.
r=mconnor
}}

Comment 2

[Alex Vincent [:WeirdAl]]

I'd be willing to take a look at this.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: Current Diff (2006.05.22)

(v1-19_XPFE -> v1-10_TK)

Comment 4

[Alex Vincent [:WeirdAl]]

Attachment: patch, v1

Okay, so the diff between toolkit and xpfe here is mainly about adding a chromedir attribute, gathered from chrome://global/locale/global.dtd.  This is built from dom/locales/jar.mn, and is included in SeaMonkey trunk builds.  The entity itself is in dom/locales/en-US/chrome/global.dtd.

Comment 5

[Alex Vincent [:WeirdAl]]

Attachment: alternative patch

This patch more closely resembles the toolkit transition plan, in that toolkit's menu.xml supersedes xpfe's in xpfe's jar.mn.  As I understand things, the toolkit transition is for trunk code only.  Per my earlier comments, I feel there is no harm in using toolkit's menu.xml now.

Comment 6

[Alex Vincent [:WeirdAl]]

<Neil> all it does is add an attribute we don't use, so I don't see the point

The differences between xpfe and toolkit are so minor that it's not felt to be worth patching.  Closing as WONTFIX; if you disagree, convince the reviewers.  :)