283019 - Stop Bugzilla::Config.pm from use-ing Bugzilla::Util

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Marc Schumann [:Wurblzap]]

There is a circular dependency between Bugzilla/Config.pm and Bugzilla/Util.pm
which keeps places like Bugzilla/Error.pm from saying
"use Bugzilla::Config qw(something)" -- the error message is "something is not
defined in %Bugzilla::Config::EXPORT_TAGS at Bugzilla/Config.pm line 36" (note
that the error occurs in Config.pm when trying to import from Error.pm).

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Max Kanat-Alexander]

Comment on attachment 175011 [details] [diff] [review]
Patch

No, Bugzilla::Config does actually use Bugzilla::Util. For example, at least
one function uses lsearch.

Comment 3

[Marc Schumann [:Wurblzap]]

(In reply to comment #2)
> No, Bugzilla::Config does actually use Bugzilla::Util. For example, at least
> one function uses lsearch.

Whoa, and here I am thinking that runtests.pl would have caught that for me...

Comment 4

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.2

Replaced lsearch by grep. Checked for other Util.pm dependencies, too.

Comment 5

[Marc Schumann [:Wurblzap]]

Frédéric, regarding the parens on grep: I call these function call parentheses.
If you don't see them as such, then the "when in doubt, parenthesize" axiom
applies here :)
[From http://aspn.activestate.com/ASPN/docs/ActivePerl/lib/Pod/perlstyle.html;
see http://www.bugzilla.org/docs/developer.html]

Comment 6

[Frédéric Buclin]

Comment on attachment 175014 [details] [diff] [review]
Patch 1.2

Ok, I have no better idea. I'm not sure parens around @{} are necessary.
r=LpSolit

Comment 7

[Max Kanat-Alexander]

For future reference, it's easier for me if the patches are a cvs diff (meaning
-p0). :-) It's not a huge issue, though.

Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.34; previous revision: 1.33
done