283670 - [Coverity] Uninitialized rowCount var in nsAutoCompleteController::RowIndexToSearch

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Brendan Eich [:brendan]]

Coverity's SWAT static analyzer suite found this one.  It's obvious, and once
you initialize rowCount to 1, the whole if (searchResult == ...FAILURE) {...}
becomes dead code.  Patch next.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

Only issue is what hewitt might have had in mind with that GetErrorDescription
call.  Might have been late-night copy-paste programming -- elsewhere, when not
failing, the error string is returned as a result string from other methods,
e.g., nsAutoCompleteController::GetResultValueAt.

Fixed a few bogusly selective or "partial" else after returns too.

/be

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 175572 [details] [diff] [review]
fix

r=dveditz

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk.  Nominate for 1.0.2 when you can.

/be