Open Bug 285508 Opened 19 years ago Updated 2 years ago

Tree Progressmeter Cells should use os theme progresschunk

Categories

(Core :: XUL, defect)

x86
All
defect

Tracking

()

People

(Reporter: garyvdm, Unassigned)

Details

Attachments

(3 files, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050310 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050310 Firefox/1.0.1

Tree Progressmeter Cells currently only render a sized image. They sould use the
OS theme style.

Reproducible: Always

Steps to Reproduce:
Status: NEW → ASSIGNED
Assignee: jan → garyvdm
Status: ASSIGNED → NEW
Attached file Testcase
Attached patch Patch v0.1 (obsolete) — Splinter Review
This is what I have done so far. Lots more to still do.
Attached patch Patch v0.2 (obsolete) — Splinter Review
1. Moved to trunk code.
2. Will still show image if one is specfied
Attachment #176954 - Attachment is obsolete: true
Attached patch Patch v0.3 (obsolete) — Splinter Review
I've now added an extra style class. So you have a style for the whole meter,
and a style for the bar.
Attachment #182330 - Attachment is obsolete: true
Attachment #182337 - Attachment is patch: false
Attachment #182337 - Attachment mime type: text/plain → image/png
Now I need to do some testing on other OS's. 
Status: NEW → ASSIGNED
Attached patch Patch 0.4Splinter Review
Just some a few things I've done to improve this patch:
Add changes to qute and pinstripe
Changed paddding on the outer box to correct the rendering in kde.
Attachment #182335 - Attachment is obsolete: true
OS: Windows XP → All
For the record, email conversation with Neil Rashbrook

Gary van der Merwe wrote:
> I saw this comment: Bug 226491 c19 and thought that maybe you can help
> me sort out undetermined side of things.
>
> I don't think it is possible to use the same solution as for Bug
> 226491, as I don't believe that it is possible to attach a xbl to a
> cell (only to the whole tree). Maybe I am wrong though.
>
> Do you have any ideas on how I can do this?

Neil Rashbrook wrote:
> No, XBL cannot be attached to tree parts. I doubt that you would be able
> to duplicate the effect of the xbl, but you might be able to emulate the
> effect if you could set a timer to repaint the cell using different
> start and end offsets for the progress chunk thus animating the chunk.
> However I don't know how you would be able to tell when to start or stop
> the animation.
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.widgets
Assignee: garyvdm → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: