Closed
Bug 285651
Opened 19 years ago
Closed 19 years ago
Opening link in new background tab confuses screen readers
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
6.79 KB,
patch
|
aaronlev
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Steps: 1. Load Window-Eyes and Mozilla or Firefox 2. While on a link, hit Ctrl+Enter Window-Eyes gets stuck in "downloading page" mode. We should not fire our page load events for pages other than the currently focused page.
Assignee | ||
Comment 1•19 years ago
|
||
This also fixes the extra "loading page" that Window-Eyes was saying when Firefox is launched.
Attachment #177097 -
Flags: review?(cbiesinger)
Comment 2•19 years ago
|
||
Comment on attachment 177097 [details] [diff] [review] 1) Only addProgressListener() on content, 2) Only listen to state changes, 3) Don't fire state_change events for loads in other documents + mWebProgress->GetIsLoadingDocument(&isLoading); hm, the isLoading variable seems write-only. can it be removed? Other than that... the change looks ok to me... but I don't know the accessibility code very well... r=biesi, but it would be great if you could get sr, or another r, from someone knowing this code.
Attachment #177097 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 177097 [details] [diff] [review] 1) Only addProgressListener() on content, 2) Only listen to state changes, 3) Don't fire state_change events for loads in other documents Biesi, thanks for noticing the extra unneeded isLoading in AddEventListeners(). I'll remove that.
Attachment #177097 -
Flags: superreview?(bzbarsky)
Assignee | ||
Updated•19 years ago
|
Attachment #177097 -
Flags: superreview?(bzbarsky)
Assignee | ||
Comment 4•19 years ago
|
||
Attachment #177097 -
Attachment is obsolete: true
Attachment #177204 -
Flags: superreview?(bzbarsky)
Attachment #177204 -
Flags: review+
Updated•19 years ago
|
Attachment #177204 -
Flags: superreview?(bzbarsky) → superreview+
Assignee | ||
Comment 5•19 years ago
|
||
Checking in src/base/nsDocAccessible.cpp; /cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v <-- nsDocAccessible.cpp new revision: 1.52; previous revision: 1.51 done Checking in src/msaa/nsDocAccessibleWrap.cpp; /cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v <-- nsDocAccessibleWrap.cpp new revision: 1.24; previous revision: 1.23 done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•