286374 - Platform and OS lose their hyperlinks (in create) when viewing

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Steve Weisberg]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: 

When entering a new bug (enter_bug.cgi), "Platform" and "OS" are hyperlinks to 
page.cgi, while when viewing a bug (show_bug.cgi) they no longer are while 
other fields remain as links. 

Reproducible: Always

Comment 1

[Sunil Joshi [:sjoshi]]

QA Contact field, also has the same problem.

Please assign this bug to me.

Comment 2

[Sunil Joshi [:sjoshi]]

While fixing this issue I got confused, how we need to implement it?
As of now, different fields are displayed differently,
one option to get a tool tip mouse icon (e.g. Product and component)
and other option is get those field name as hyper links itself(Importance and Assigned to)

Please let me know the approach we need to follow in this case.

Comment 3

[Frédéric Buclin]

We should be using bug/field-label.html.tmpl everywhere.

Comment 4

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v1

Fixed for Version, platform and QA contact field, there is no *OS* label field in view bug page.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 675860 [details] [diff] [review]
Patch-v1

Review of attachment 675860 [details] [diff] [review]:
-----------------------------------------------------------------

Need to include the accesskeys for fields that still have them at least. Can fix on commit.

r=dkl

::: template/en/default/bug/edit.html.tmpl
@@ +269,5 @@
>      [%# PLATFORM #%]
>      [%############%]    
>      <tr>
> +      [% INCLUDE "bug/field-label.html.tmpl"
> +        field = bug_fields.rep_platform editable = 1 %]

accesskey = 'h'

@@ +411,5 @@
>  
>      [% IF Param('useqacontact') %]
>      <tr>
> +      [% INCLUDE "bug/field-label.html.tmpl"
> +        field = bug_fields.qa_contact editable = 1 %]

accesskey = 'q'

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 675860 [details] [diff] [review]
Patch-v1

Review of attachment 675860 [details] [diff] [review]:
-----------------------------------------------------------------

Actually please submit a new patch that has the accesskey fixes as well as fixes the Whiteboard label and I will review that.

::: template/en/default/bug/edit.html.tmpl
@@ +269,5 @@
>      [%# PLATFORM #%]
>      [%############%]    
>      <tr>
> +      [% INCLUDE "bug/field-label.html.tmpl"
> +        field = bug_fields.rep_platform editable = 1 %]

accesskey = 'h'

@@ +411,5 @@
>  
>      [% IF Param('useqacontact') %]
>      <tr>
> +      [% INCLUDE "bug/field-label.html.tmpl"
> +        field = bug_fields.qa_contact editable = 1 %]

accesskey = 'q'

Comment 7

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v2

Fixed Access key for QA Contact and Hardware and handled whiteboard case also.

Comment 8

[David Lawrence [:dkl]]

Comment on attachment 675928 [details] [diff] [review]
Patch-v2

Review of attachment 675928 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good other than nit which I can fix on checkin. r=dkl

::: template/en/default/bug/edit.html.tmpl
@@ +270,5 @@
>      [%############%]    
>      <tr>
> +      [% INCLUDE "bug/field-label.html.tmpl"
> +        field = bug_fields.rep_platform editable = 1
> +        accesskey = "h" %]        

nit: each on its own line

 [% INCLUDE "bug/field-label.html.tmpl"
    field = bug_fields.rep_platform 
    editable = 1
    accesskey = "h" 
  %]

@@ +412,5 @@
>      [% IF Param('useqacontact') %]
>      <tr>
> +      [% INCLUDE "bug/field-label.html.tmpl"
> +        field = bug_fields.qa_contact editable = 1
> +        accesskey = "q" %]

same

Comment 9

[David Lawrence [:dkl]]

Thanks for the patch!

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified template/en/default/bug/edit.html.tmpl
Committed revision 8452.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4
modified template/en/default/bug/edit.html.tmpl
Committed revision 8438. 

dkl

Comment 11

[Frédéric Buclin]

There is a problem with the fix on checkin. When splitting the long line into several lines as described in comment 8,

  field = bug_fields.rep_platform

became

  field = bug_fields.
  rep_platform


I'm surprised that TT didn't complain. But I'm fixing this anyway to make the code clearer:

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/bug/edit.html.tmpl
Committed revision 8642.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified template/en/default/bug/edit.html.tmpl
Committed revision 8571.