Closed Bug 286392 Opened 19 years ago Closed 19 years ago

String concatenation on postgres does not always work

Categories

(Bugzilla :: Bugzilla-General, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: Tomas.Kopal, Assigned: Tomas.Kopal)

References

Details

Attachments

(1 file)

Postgres concat operator has relatively low priority, we need to put braces
around it to avoid problems when used in complex expressions. This problem does
not affect MySQL, as it does not use operator but function.
Patch will follow.
Attached patch V1Splinter Review
Added braces around string concatenation for postgres and generic ANSI.
Attachment #177603 - Flags: review?(mkanat)
Comment on attachment 177603 [details] [diff] [review]
V1

Oh funny, I was thinking about that when we wrote the CONCAT patch, too, I just
must have forgotten to mention it in review. :-)
Attachment #177603 - Flags: review?(mkanat) → review+
Status: NEW → ASSIGNED
Flags: blocking2.20?
Flags: approval?
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.20
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.33; previous revision: 1.32
done
Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: