286525 - Installing / updating a theme creates a copy of the jar in the chrome directory

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050316 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050316 Firefox/1.0+

When installing a theme for the first time or updating an existing theme a copy
of the theme's jar file is placed in the profile's chrome directory. When there
is already a file with the same name located there a -# is appended to the file
name (e.g. theme-2.jar) which will then cause updates to themes to create a
second jar file in the theme's chrome directory instead of replacing the
existing jar file. This is a spin off of bug 251026.

Reproducible: Always

Steps to Reproduce:
1. install or update a theme
Actual Results:  
There is a copy of the jar file for the theme in the profile's chrome directory.

Expected Results:  
No extra jar files hanging around

Comment 1

[Caleb]

Just like Bug 271220 ?

Comment 2

[Robert Strong (they/them - no direct email)]

(In reply to comment #1)
> Just like Bug 271220 ?
Actually no, that bug describes a problem that existed with the EM code prior to
the recent EM landing where upgrading a theme would leave multiple theme jar
files in the theme's chrome directory and I am pretty sure that bug 271220 is
fixed by the EM landing. What this describes is the theme's jar file being
copied into the profile's chrome directory.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: simple patch

Dan - This is a simple one liner. This patch moves the closing of the zip
reader to before the zip file is deleted. This is located in #ifdef MOZ_XUL_APP
so it should not affect seamonkey.

requesting rs

Comment 4

[Robert Strong (they/them - no direct email)]

Nominating due to this being a simple fix and without this patch there are
issues with the new chrome.manifest files since this bug causes the jar filename
to change.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 182070 [details] [diff] [review]
simple patch

I found a second issue that looks like it will require a modification to this
same code so I am clearing review. I should be done within the next day with an
updated patch

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch

This patch moves the closing of the zip reader to before the zip file is
deleted and adds a param to nsIExtensionManager::installItemFromFile that bug
292506 will need. This change is located in an #ifdef MOZ_XUL_APP so it should
not affect seamonkey. This would need to be landed with the patch from bug
292506.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 182813 [details] [diff] [review]
patch

a=asa

Comment 9

[Robert Strong (they/them - no direct email)]

checked in - thanks timelyx - resolved fixed.