Closed
Bug 286542
Opened 19 years ago
Closed 19 years ago
in the html source of owners.html, each module owner and peer should be on a separate line
Categories
(Webtools Graveyard :: Despot, enhancement)
Webtools Graveyard
Despot
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: steffen.wilberg, Assigned: jwatt)
References
()
Details
Attachments
(1 file, 2 obsolete files)
2.01 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
It would be nice if the module owners and peers would be on a separate line each in the html source of owners.html, to make diff and blame useful. The display of the file in a browser would not be affected.
Reporter | ||
Updated•19 years ago
|
Assignee | ||
Comment 1•19 years ago
|
||
Some people are never happy. ;-) I agree, this would be better. Since I fixed bug 245664 I'll take this one as well.
Assignee: justdave → jonathan.watt
Assignee | ||
Comment 2•19 years ago
|
||
The Owners mailto is a URI, so I can't split it over multiple lines. However, you should be able to tell which peer(s) have been added/removed more easily with this patch.
Attachment #177735 -
Flags: review?(myk)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•19 years ago
|
||
Umm, oops. More haste less speed. That should be: + print OWNERS qq| + </td> of course.
Reporter | ||
Comment 4•19 years ago
|
||
Thanks for taking this! Some modules have more than one owner, e.g. http://www.mozilla.org/owners.html#standalone-mail. Those should be on a separate line as well. That's what I meant.
Assignee | ||
Comment 5•19 years ago
|
||
Ah, okay. How about this then?
Attachment #177740 -
Flags: review?(myk)
Comment 6•19 years ago
|
||
Comment on attachment 177740 [details] [diff] [review] alternative patch - puts owner names on separate lines Escape characters aren't interpolated in single-quoted strings, so the join string needs to be double-quoted. Otherwise this looks good and works well.
Attachment #177740 -
Flags: review?(myk) → review-
Updated•19 years ago
|
Attachment #177735 -
Flags: review?(myk)
Assignee | ||
Comment 7•19 years ago
|
||
Okay, this should fix that.
Attachment #177735 -
Attachment is obsolete: true
Attachment #177740 -
Attachment is obsolete: true
Attachment #177779 -
Flags: review?(myk)
Updated•19 years ago
|
Attachment #177779 -
Flags: review?(myk) → review+
Assignee | ||
Comment 8•19 years ago
|
||
Checked in. Marking fixed. Checking in mozilla/webtools/despot/syncit.pl; /cvsroot/mozilla/webtools/despot/syncit.pl,v <-- syncit.pl new revision: 1.31; previous revision: 1.30 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•