286873 - Crash on proxy icon drag if the associated page has a null title.

Status: RESOLVED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[Wevah (Nate Weaver)]

Go to a page with no title tag and attempt to drag the proxy icon on the URL
bar. Chances are, you'll see a crash.

Testcase *and* easy patch forthcoming.

Comment 1

[Wevah (Nate Weaver)]

Attachment: Testcase.

Comment 2

[Wevah (Nate Weaver)]

Attachment: Proposed patch.

This makes sure |title| is non-nil, and since we've already put the URL data
into the same var, it should use the URL as the title if |title| *is* nil.

Comment 3

[Wevah (Nate Weaver)]

Whoops, changing keywords and assignee (to myself).

(I wonder if this qualifies for the "contributor" list...).

Comment 4

[Wevah (Nate Weaver)]

Comment on attachment 177973 [details] [diff] [review]
Proposed patch.

I'm gonna check for a reviewer in IRC, but it's so simple a fix it might not
even need more than one look over (if that).

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 177973 [details] [diff] [review]
Proposed patch.

sr=pink.

Comment 6

[Simon Fraser [no longer active]]

Checked in.