Closed Bug 287615 Opened 19 years ago Closed 19 years ago

move openPreferences() to utilityOverlay

Categories

(Firefox :: Settings UI, defect, P1)

PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file)

In bug 267227, I moved the mac preferences menu item to baseMenuOverlay.
However, I forgot to move the openPreferences() method to utilityOverlay, this
means we still can't use the preferences menu item in !browser windows.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox1.1
Attached patch patchSplinter Review
In hope you're still reading :)
Attachment #178517 - Flags: review?
Comment on attachment 178517 [details] [diff] [review]
patch

you=mike...
Attachment #178517 - Flags: review? → review?(mconnor)
Attachment #178517 - Flags: review?(mconnor) → review+
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.404; previous revision: 1.403
done
Checking in utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.17; previous revision: 1.16
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: