288098 - Mozilla can't start when creating a new profile at the first time.

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Boying Lu]

Steps to Reproduce:
1. Install Cinnabar31
2. Open a terminal, run "rm -rf .mozilla", "rm -rf .java".
3. Still in the terminal, run "mozilla -P".
4. In Create Profile Wizard dialog, click Next.
5. Click Finish to create a new profile by the default name.

Bug Observation:
Mozilla can't start this time and error message in the terminal: 
"Application Finalize Called"
When you start Mozilla again, it can start up.

Comment 1

[Boying Lu]

Attachment: patch

Comment 2

[[e-mail]]

Why are you starting Mozilla with just -P ?

Comment 3

[[e-mail]]

Comment on attachment 178918 [details] [diff] [review]
patch

I wonder if we should do anything in the Cancel case...

>+    dialogParams.SetInt(0,1); //since this is the only one profile avaiable, use it
Nit: space after comma please. Also that comment is inaccurate, as this code is
also used by the -ProfileWizard function.

Comment 4

[Boying Lu]

Attachment: revised

Comment 5

[[e-mail]]

Comment on attachment 179154 [details] [diff] [review]
revised 

>+    dialogParams.SetInt(0, 1); //set the newly created profile as the defult
Nit: typo: "default"

Comment 6

[Boying Lu]

Attachment: another one

Sorry, for the mistake

Comment 7

[Boying Lu]

Attachment: another one

Sorry for the mistake

Comment 8

[Conrad Carlen (not reading bugmail)]

Comment on attachment 179160 [details] [diff] [review]
another one

Does this bug mean that the -ProfileWizard switch is broken as well? Looks like
it would hit this as well. Starting with no profile, -P without a value, and
having the CreateProfile wizard come up is wrong. I see why it's happening but,
really -P should require a profile name. The command line handler returns "1"
for params with no value and that's why we end up bringing up the profile
wizard.

If the -ProfileWizard switch is broken and this fixes it, r=ccarlen. The
'Cancel' case should work because nsDialogParamBlock inits all values to 0, but
I'd rather see it done explicitly in the code you added.

Comment 9

[Boying Lu]

Thanks. Can we check in th patch now?

Comment 10

[[e-mail]]

Done, leaving the bug open in case someone wants to resolve comment 8.

Comment 11

[Stefan [:stefanh]]

Comment on attachment 179159 [details] [diff] [review]
another one

Removing obsolete requests...

Comment 12

[Philip Chee]

Comment on attachment 179154 [details] [diff] [review]
revised 

> Removing obsolete requests...
You missed one.

Comment 13

[Robert Kaiser]

(In reply to comment #10)
> Done, leaving the bug open in case someone wants to resolve comment 8.

Actually, please, let's close a bug that has almost all this work done - and if that other problem still is there, please file a new bug to track that other thing individually.