288194 - XUL <textbox> is too hard to focus

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050329
Firefox/1.0+

repro:
1.Open Firefox (probably the same in Seamonkey)
2.Move the mouse over the locationbar to focus
3.The area that takes focus is only the width and height of the text
4.html <input>, <textarea> takes focus as soon as the mouse is inside the border

This behaviour makes it very easy to miss the focusarea and type stuff that
never is displayed becaused you missed the focus again.

expected:
the XUL <textbox> should accept focus inside the border, like <input> and <textarea>

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Screenshot of where onmouseclick sets focus to the box.
Top: XUL <textbox>
Bottom: html <input type="text"> (same for any other form element)

Comment 2

[Peter van der Woude [:Peter6]]

? FF1.1 (I'm not sure if that's allowed)

I have been mishitting <textbox> -es way too long

Comment 3

[Asaf Romano (gone)]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050325
Firefox/1.0+

WFM

Comment 4

[Worcester12345]

I thought it was the "Find as you type" bug coming back again. Was that one even
ever fixed? You know, the bug where FAYT just started for no good reason.

Comment 5

[Peter van der Woude [:Peter6]]

(In reply to comment #4)
> I thought it was the "Find as you type" bug coming back again. Was that one even
> ever fixed? You know, the bug where FAYT just started for no good reason.
This misfocus may well be the reason for FAYT to start

Comment 6

[Pavel Penaz]

This focus issue is really very irritating, I always have to check twice to make
sure that find toolbar has focus.

Comment 7

[Peter van der Woude [:Peter6]]

Attachment: findbar focusarea loss

I enlarged the Findbar 10 times to show the actuall number pixels that won't
accept focus at mousedown.

Comment 8

[Peter van der Woude [:Peter6]]

CC Neil Deakin
Any chance you could help us Neil?

Comment 9

[Peter van der Woude [:Peter6]]

Oops, wrong Neil CC's
This time better (I hope)

Comment 10

[[e-mail]]

I'm not Neil Deakin either but I suspect you'd need to programatically focus the
inner input whenever the mouse is clicked anywhere within the xul textbox;
currently the context menu code has a specific workaround to focus it.

Comment 11

[Peter van der Woude [:Peter6]]

(In reply to comment #10)
> I'm not Neil Deakin either but I suspect you'd need to programatically focus the
> inner input whenever the mouse is clicked anywhere within the xul textbox;
> currently the context menu code has a specific workaround to focus it.
Boris suggested me to CC you.
I know, an easy hack is adding onclick="focus();" to every textbox , but it
isn't solving the problem offcourse.

Comment 12

[[e-mail]]

(In reply to comment #11)
>I know, an easy hack is adding onclick="focus();" to every textbox, but it
>isn't solving the problem of course.
Then what sort of solution are you looking for?
http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/textbox.xml#97
is a central location where we can add mouse handlers to every textbox.
Note: I would a) prefer to use mousedown rather then click b) directly focus the
inputField c) check that the inputField is not disabled first.

Comment 13

[Peter van der Woude [:Peter6]]

(In reply to comment #12)
> Then what sort of solution are you looking for?

I am looking for the <textbox> to get focus if mousedown happens anywhere inside
or on the border of the element.
Equal to the mousedown behaviour on any formelement in html

> http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/textbox.xml#97
> is a central location where we can add mouse handlers to every textbox.
> Note: I would a) prefer to use mousedown rather then click b) directly focus the
> inputField c) check that the inputField is not disabled first.

I'm a no-coder :-(

Comment 14

[Asaf Romano (gone)]

taking.

Comment 15

[Asaf Romano (gone)]

Attachment: testcase

Comment 16

[Peter van der Woude [:Peter6]]

Attachment: testcase 2

the bottom 2 boxes is how it "should" work.

Comment 17

[Worcester12345]

(In reply to comment #6)
> This focus issue is really very irritating, I always have to check twice to make
> sure that find toolbar has focus.

I have to check twice to make sure it DOESN'T have focus.

Comment 18

[Benjamin Smedberg]

Not a blocker, but patches are still welcome.

Comment 19

[José Jeria]

*** Bug 289841 has been marked as a duplicate of this bug. ***

Comment 20

[Martijn Wargers (dead)]

Well, what seems to work for the url bar for me is:
.autocomplete-textbox-container {
  -moz-box-align: stretch; }, instead of -moz-box-align: center;

Comment 21

[[e-mail]]

(In reply to comment #20)
> Well, what seems to work for the url bar for me is:
> .autocomplete-textbox-container {
>   -moz-box-align: stretch; }, instead of -moz-box-align: center;
I thought that was necessary to work properly with large fonts...

Comment 22

[Dão Gottwald [:dao]]

Attachment: patch

Comment 23

[Neil Deakin]

Comment on attachment 340430 [details] [diff] [review]
patch


>+            if (event.originalTarget == this ||
>+                /(?:\s|^)textbox-input-box(?:\s|$)/.test(event.originalTarget.className))
>+              this.inputField.focus();

Why can't you just add an anonid to the box, or just use this.inputField.parentNode here?

Comment 24

[Dão Gottwald [:dao]]

I'd have to add the anonid to different bindings, let alone bindings that we don't control. But inputField.parentNode seems fine.

Comment 25

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 26

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/60221b1e9513