28836 - div is not hidden and show correctly when it contains a GfxButtonControl

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Comment 1

[rods (gone)]

making beta

Comment 2

[rods (gone)]

Attachment: simple test case

Comment 3

[rods (gone)]

buttons and selects cause it to not work
radio, checkboxes and input text work fine

Comment 4

[Marc Attinasi]

Attachment: XUL file that originally showed the problem - for verification

Comment 5

[leger]

Putting on PDT+ radar for beta1.  Can you give you an estimate on time needed to 
fix in the Status Summary please?  Thanks!

Comment 6

[Marc Attinasi]

So far I have seen that there is some sort of problem in resolving the style for 
the DIV AFTER the frames and style context's have been destroyed and while they 
are being recreated. The DIV's area frame is having its style resolved, but we 
find an existing style rule on one of the parent's children so we use that 
instead of creating a new one. More accurately, for the cases that fail, the 
call to FindChildWithRules inside of StyleSetImpl::GetContext is finding a child 
context, whereas in the cases that are OK there is no child context with 
matching rules. When I trace the StyleContextImpl's destruction it appears 
to be correct, so I don't understand yet why we are finding a child with 
matching rules. That's all I know so far... 

I have narrowed down the code where the symptoms appear. I'd guess it will take 
me another day to find and fix to underlying cause, so it should be closed by 
tomorrow evening.

Comment 7

[Marc Attinasi]

Actually, buttons appear to be the only thing that makes it not work... all 
other elements I have tried work fine.

Comment 8

[leger]

Adding Est fix date to Status Whitboard

Comment 9

[Marc Attinasi]

It is ollking like a ref-count problem on one of the style contexts for the 
input element (button). I am trying to figure out where it is occuring... 

I think it may be a problem with the parenting of the style contexts because the 
ref counts appear to be off, but additionally there is a strange child context I 
cannot yet account for that appears to be holding the lingering reference to the 
context.

I bumped the estimated time to fix by a day.

Comment 10

[Marc Attinasi]

Additional info: if the control in the DIV is an HTML <BUTTON> it works fine. If 
it is a <SELECT> it is broken. Essentially, every case that fails involves a 
GfxButton, and if there is no GfxButton it appears to be fine...

Comment 11

[Marc Attinasi]

Updated the summary to reflect the latest findings...

Comment 12

[Marc Attinasi]

Fixed. A StyleContext was not being released and was causing the entire 
parentage to be retained and reused. I fixed it but found that pollman had 
already checked in the same fix for a seperate bug (bug 28691).

Comment 13

[Prashant Desale]

Tested with 03-08-09, and it works fine. Used provided testcase attachments to 
verify. Marking verified.