288412 - Image Blocking fails in 3-29 builds

Status: VERIFIED FIXED

(Core :: Graphics: Image Blocking, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

I suspect bug 287628 broke Image Blocking by domain in Seamonkey, build
2005-03-30-06, Windows XP trunk.

Sites are correctly added to the Image Manager, and prefs seem to be correctly
selected/enabled (i.e. 'Block Images from this Site' is active in the menu item
for each site I visit which has an entry in the Image Manager), but the images
still display.

[02:58] <Matti> stephend: block images seems to work in my 0327 build. Could be
that fix from 0329

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Updating summary to reflect that since bug 287628 landed before the build
cutoff, which I believe is somewhere around 5 a.m., this really broke starting
with the 3-29 builds.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

bug 279535 comment 14 kind of explains why perms.dll wasn't added to the
installer manifests. looks like i was wrong there.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 281000 has been marked as a duplicate of this bug. ***

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: possible patch

i can't test this patch, for the lack of a windows box. But i hope it will do
the trick. (I didn't add to this file initially, because i was confused that
libcookie.dll etc were not in there. Until i found out they are in the gre)

Comment 5

[Benjamin Smedberg]

Comment on attachment 179508 [details] [diff] [review]
possible patch

r=me, no sr needed

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Patch checked in. However, i don't have a windows installer, so leaving this
open until someone can test if the bug is really fixed.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> Patch checked in. However, i don't have a windows installer, so leaving this
> open until someone can test if the bug is really fixed.

I'll take care of that with tomorrow's build, and I'll let you know whether it's
fixed or not.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

I've heard it is indeed fixed.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Indeed it is.  Verified with build Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.8b2) Gecko/20050406 on Windows XP Seamonkey trunk.