28859 - HTML intelligent send fires upon Save as Draft/Template

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[laurel]

Using feb 22 builds, all platforms

The HTML Intelligent Send question dialog fires upon saving a message
composition as Draft or Template.  The intelligent send stuff shouldn't surface
until we send the message. 

1.  Edit|Prefs|Mail&newsgroups|Formatting. Enable the first option "Ask me what
to do when message has HTML formatting" (default).
2.  Compose an html message to test9@foobar
3.  From the compose window, File|Save As|Draft.
   
Result:  HTML Intelligent Send dialog displays asking about what format in which
to send the message.

Expected result:  Message should save to draft without asking about format. 
Formatting question should be asked upon sending the message.

Comment 1

[laurel]

Correcting summary

Comment 2

[Jean-Francois Ducarroz]

Accepting. Should be am easy fix.

Comment 3

[leger]

Moving dogfood to keyword field from Status Summary.

Comment 4

[leger]

Putting on PDT- radar for dogfood. An annoyance, but will not hold for this.

Comment 5

[Jean-Francois Ducarroz]

The easy fix is o check is we are sending now or later the message before 
checking for eventual HTML formatting conflict.

Index: MsgComposeCommands.js
===================================================================
RCS file: 
/cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v
retrieving revision 1.73
diff -r1.73 MsgComposeCommands.js
451,479c451,482
<
<                   // Before sending the message, check what to do with HTML 
message, eventually abort.
<             action = DetermineHTMLAction();
<             if (action == msgCompSendFormat.AskUser)
<             {
<                 var result = {action:msgCompSendFormat.PlainText, 
abort:false};
<                   
window.openDialog("chrome://messengercompose/content/askSendFormat.xul",
<                                       "askSendFormatDialog", "chrome,modal",
<                                       result);
<                   if (result.abort)
<                       return;
<                    action = result.action;
<             }
<             switch (action)
<             {
<                 case msgCompSendFormat.PlainText:
<                     msgCompFields.SetTheForcePlainText(true);
<                     msgCompFields.SetUseMultipartAlternativeFlag(false);
<                     break;
<                 case msgCompSendFormat.HTML:
<                     msgCompFields.SetTheForcePlainText(false);
<                     msgCompFields.SetUseMultipartAlternativeFlag(false);
<                     break;
<                 case msgCompSendFormat.Both:
<                     msgCompFields.SetTheForcePlainText(false);
<                     msgCompFields.SetUseMultipartAlternativeFlag(true);
<                               break;
<                default: dump("\###SendMessage Error: invalid action value\n"); 
return;
<             }
---
>
>                       if (msgType == msgCompDeliverMode.Now || msgType == 
msgCompDeliverMode.Later)
>                       {
>                               // Before sending the message, check what to do 
with HTML message, eventually abort.
>                               action = DetermineHTMLAction();
>                               if (action == msgCompSendFormat.AskUser)
>                               {
>                                       var result = 
{action:msgCompSendFormat.PlainText, abort:false};
>                                       
window.openDialog("chrome://messengercompose/content/askSendFormat.xul",
>                                                                               
"askSendFormatDialog", "chrome,modal",
>                                                                               
result);
>                                       if (result.abort)
>                                               return;
>                                        action = result.action;
>                               }
>                               switch (action)
>                               {
>                                       case msgCompSendFormat.PlainText:
>                                               
msgCompFields.SetTheForcePlainText(true);
>                                               
msgCompFields.SetUseMultipartAlternativeFlag(false);
>                                               break;
>                                       case msgCompSendFormat.HTML:
>                                               
msgCompFields.SetTheForcePlainText(false);
>                                               
msgCompFields.SetUseMultipartAlternativeFlag(false);
>                                               break;
>                                       case msgCompSendFormat.Both:
>                                               
msgCompFields.SetTheForcePlainText(false);
>                                               
msgCompFields.SetUseMultipartAlternativeFlag(true);
>                                               break;
>                                  default: dump("\###SendMessage Error: invalid 
action value\n"); return;
>                               }
>                       }

Comment 6

[Jean-Francois Ducarroz]

Code reviewed by mscott

Comment 7

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 8

[Jean-Francois Ducarroz]

Change TM to M15

Comment 9

[fenella]

Linux (2000-03-17-08 M15) commercial trunk
MAc (2000-03-17-08 M15) commercial trunk
Win 32 (2000-03-17-09 M15) commercial trunk
This problem is fixed in the trunk builds of all 3 platforms. Need to test it in
the beta 1 build.

Comment 10

[fenella]

Per ducarroz, this is is PDT- bug, so it would not be in the beta1 builds. 
Mark it verified.