Closed
Bug 288696
Opened 19 years ago
Closed 19 years ago
HandleMDNResponse should not be returning 0
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
1.19 KB,
patch
|
mscott
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Bienvenu suggest that this should be patched on TB too. Quoting from Neil's comments in bug 288529 var mimeHdr; try { mimeHdr = aUrl.mimeHeaders; } catch (ex) { return 0;} This shouldn't be returning 0 here, because our version at least of HandleMDNResponse does not return a value. Also the return should be on its own line, the compact catch syntax only applies when you're only want to ignore exceptions.
This patch: * Does return instead of return 0 * Does not use compact form of catch * Does some whitespace tidy up round code being changed
Attachment #179323 -
Flags: superreview?(bienvenu)
Attachment #179323 -
Flags: review?(mscott)
Updated•19 years ago
|
Attachment #179323 -
Flags: superreview?(bienvenu) → superreview+
Updated•19 years ago
|
Attachment #179323 -
Flags: review?(mscott) → review+
Comment on attachment 179323 [details] [diff] [review] Patch v0.1 (Checked in) Checking in mailWindowOverlay.js; /cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v <-- mailWindowOverlay.js new revision: 1.86; previous revision: 1.85 done
Attachment #179323 -
Attachment description: Patch v0.1 → Patch v0.1 (Checked in)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•