Closed Bug 289148 Opened 19 years ago Closed 10 years ago

nsPluginInstallerWizard.prototype.loadURL should use the webpage to open a new window, not chrome

Categories

(Toolkit Graveyard :: Plugin Finder Service, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: doronr, Assigned: doronr)

Details

Attachments

(1 file)

This is the real fix for security bug 288556.

window.opener points to chrome, we should rather use an html webpage.
Attached patch patchSplinter Review
Attachment #181796 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 181796 [details] [diff] [review]
patch

window.opener.content.open perhaps?
Is there any advantage to useing .content?
Product: Firefox → Toolkit
(In reply to Doron Rosenberg (IBM) from comment #3)
> Is there any advantage to useing .content?
Flags: needinfo?(neil)
.content is a convenient shorthand for .getBrowser().mCurrentBrowser.contentWindow but has the other advantage in that it's more generic code (e.g. doesn't rely on an implementation detail of tabbrowser, so might work in Thunderbird too).
Flags: needinfo?(neil)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Product: Toolkit → Toolkit Graveyard
Comment on attachment 181796 [details] [diff] [review]
patch

cancelling review on dead bug
Attachment #181796 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: