289794 - accesskeys for "Mail" and "News" checkboxes in Default Settings/application section are both "d"; the accesskey "D" is dispalyed if the preferences dialog was opened with a pane other than General

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Steffen Wilberg]

I'm using a trunk build compiled today on Linux/GTK2.

The accesskeys for "Mail" and "News" checkboxes in Preferences->General->Default
Settings are both "d". If you click alt+d, the "News" checkbox is toggled.

The wrong accesskeys are only displayed if the preferences dialog was opened
with a pane other than General. It then looks like this:
  Mail (D)  Check Now
  News (D)  Check Now

Steps to reproduce:
1. Open the preferences dialog.
2. Select a pane other than General.
3. Close the preferences dialog and open it again.
4. Select the General pane.

Comment 1

[Mike Cowperthwaite]

Hm; I don't have Linux to check with, but in Windows, the trunk builds have a 
redesigned Options panel (icons along the top) which restructure the 'default' 
settings.

There *is* still an access-key conflict:  'R' is the key for 'RSS' as default, 
and also for the "Restore Default" button under the Start Page.


Under Windows, TB 1.0.2 has no access keys for the 'default' settings.

Comment 2

[Steffen Wilberg]

I'm using a trunk build as well, from April 07 (with e.g. the config editor
button in the Advanced options panel).

It does look different on Windows. In Linux/GTK2, it looks like described in
comment 0.
http://lxr.mozilla.org/seamonkey/source/mail/components/preferences/general.xul#81

Comment 3

[Steffen Wilberg]

-> me.

Comment 4

[Steffen Wilberg]

Attachment: patch

This patch fixes the problems mentioned in comment 0, comment 1, and provides
different accesskeys for the "Check Now" buttons. It also removes two lines
which were twice in general.dtd.

Comment 5

[Scott MacGregor]

Comment on attachment 180780 [details] [diff] [review]
patch

thanks Steffen. Feel free to check this in.

Comment 6

[Steffen Wilberg]

Checking in mozilla/mail/components/preferences/general.xul;
/cvsroot/mozilla/mail/components/preferences/general.xul,v  <--  general.xul
new revision: 1.2; previous revision: 1.1
done
Checking in mozilla/mail/locales/en-US/chrome/messenger/preferences/general.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/preferences/general.dtd,v 
<--  general.dtd
new revision: 1.4; previous revision: 1.3
done