Closed Bug 289927 Opened 19 years ago Closed 18 years ago

JS Console shouldn't show line number if line is 0.

Categories

(Toolkit Graveyard :: Error Console, defect)

Product:
Toolkit Graveyard
Component:
Error Console
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta2

People

(Reporter: doronr, Assigned: doronr)

Details

(Keywords: fixed-seamonkey1.1a, fixed1.8.1, Whiteboard: [verified-seamonkey1.1a])

Attachments

(1 file, 3 obsolete files)

use class name rather than id [Checkin: Comment 6 and 14]
1.77 KB, patch
mconnor
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review 
No good toolkit component to file this in.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #180381 -
        Flags: first-review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 180381 [details] [diff] [review]
patch

>+            <xul:hbox id="lineNumberRow" xbl:inherits="line">
>+              <xul:label class="label" value="&errLine.label;"/>
>+              <xul:label class="label" xbl:inherits="value=line" flex="1"/>
>+            </xul:hbox>
The box should use a class, not an id. Also, the box doesn't flex, which makes
the flex of its last child pretty pointless.

Note that flexing the box will make the layout minusculely different from the
original console layout (i.e. don't worry about it).

        Attachment #180381 -
        Flags: first-review?(neil.parkwaycc.co.uk) → first-review-

    
  

        Attachment #180489 -
        Flags: first-review?(neil.parkwaycc.co.uk)

        Attachment #180489 -
        Flags: first-review?(neil.parkwaycc.co.uk) → first-review+

    
  
Component: Toolbars and Toolbar Customization → Error Console
Flags: first-review-
Flags: first-review+
Product: Toolkit → Firefox
Hardware: PC → All
Target Milestone: --- → Firefox 2 beta2
Version: unspecified → 2.0 Branch

    
    

    
  
Amazingly this patch still applies. I just hope that Gavin believes that mconnor's r+ was eaten by BugZilla while moving this bug to the correct product. :)
Whiteboard: [checkin needed]

    
    

    
  
Comment on attachment 180489 [details] [diff] [review]
use class name rather than id
[Checkin: Comment 6 and 14]

Restoring missing r=me

        Attachment #180489 -
        Flags: review+

    
    

    
  
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]

    
    

    
  


  
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060717 SeaMonkey/1.1a] (nightly) (W98SE)

Port/Copy Toolkit patch to XPFE,
with additional space nits fixes.

Successfully tested on 1.8 branch.

        Attachment #229776 -
        Flags: superreview?(neil)

        Attachment #229776 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 229776 [details] [diff] [review]
(Bv1-XPFE) <consoleBindings.xml>++
[Checkin: Comment 13]

Seems that for comment 2 I applied the patch to xpfe and I've been using it like that since then ;-)

        Attachment #229776 -
        Flags: superreview?(neil)

        Attachment #229776 -
        Flags: superreview+

        Attachment #229776 -
        Flags: review?(neil)

        Attachment #229776 -
        Flags: review+

    
    

    
  
Comment on attachment 229776 [details] [diff] [review]
(Bv1-XPFE) <consoleBindings.xml>++
[Checkin: Comment 13]

'approval1.8.1=?': (SeaMonkey only)
Simple U.I. code enhancement, no risk.

        Attachment #229776 -
        Flags: approval1.8.1?

    
    

    
  


  
Additional space nits fixes, from the XPFE patch.

        Attachment #229827 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 229776 [details] [diff] [review]
(Bv1-XPFE) <consoleBindings.xml>++
[Checkin: Comment 13]

a=drivers, please go ahead and land on the 1.8.1branch

        Attachment #229776 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Comment on attachment 229827 [details] [diff] [review]
(Cv1-TK) <console.css>
[Checkin: Comment 12 and 14]

I checked this in on the trunk:
mozilla/toolkit/components/console/content/console.css 	1.5

        Attachment #229827 -
        Flags: review?(mconnor)

    
    

    
  
mozilla/xpfe/components/console/resources/content/consoleBindings.xml 	1.24
mozilla/xpfe/components/console/resources/content/console.css 	1.6
mozilla/xpfe/components/console/resources/content/consoleBindings.xml 	1.23.8.1
mozilla/xpfe/components/console/resources/content/console.css 	1.5.66.1
Keywords: fixed-seamonkey1.1a

    
    

    
  
mozilla/toolkit/components/console/content/consoleBindings.xml 	1.9.2.2
mozilla/toolkit/components/console/content/console.css 	1.3.56.1
Keywords: fixed1.8.1

    
    

    
  
Comment on attachment 180489 [details] [diff] [review]
use class name rather than id
[Checkin: Comment 6 and 14]

'approval1.8.1=?': (Toolkit only)
Simple U.I. code enhancement, no risk.
To synchronize with XPFE.

        Attachment #180489 -
        Flags: approval1.8.1?

    
    

    
  
(In reply to comment #15)
> (From update of attachment 180489 [details] [diff] [review] [edit])
> 'approval1.8.1=?': (Toolkit only)

Well, Gavin checked it in to the branch (with "a=beltzner") while I was asking for approval...

        Attachment #229776 -
        Attachment description: (Bv1-XPFE) <consoleBindings.xml>++ → (Bv1-XPFE) <consoleBindings.xml>++
[Checkin: Comment 13]

        Attachment #229776 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 229827 [details] [diff] [review]
(Cv1-TK) <console.css>
[Checkin: Comment 12 and 14]

'approval1.8.1=?': (Toolkit only)
From Trunk checkin:
"Fix whitespace nits to sync with xpfe, r=sparky",
no risk.

        Attachment #229827 -
        Attachment description: (Cv1-TK) <console.css> → (Cv1-TK) <console.css>
[Checkin: Comment 12]

        Attachment #229827 -
        Attachment is obsolete: true

        Attachment #229827 -
        Flags: approval1.8.1?

        Attachment #229827 -
        Attachment is obsolete: false
No longer blocks: 344955

    
    

    
  
Comment on attachment 180489 [details] [diff] [review]
use class name rather than id
[Checkin: Comment 6 and 14]

a=drivers

        Attachment #180489 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Comment on attachment 229827 [details] [diff] [review]
(Cv1-TK) <console.css>
[Checkin: Comment 12 and 14]

a=drivers, perhaps post-hoc!

        Attachment #229827 -
        Flags: approval1.8.1? → approval1.8.1+

        Attachment #180489 -
        Attachment description: use class name rather than id → use class name rather than id
[Checkin: Comment 6 and 14]
Whiteboard: [checkin needed (1.8 branch): Cv1-TK]

    
    

    
  
All these patches are already checked in.
Whiteboard: [checkin needed (1.8 branch): Cv1-TK]

    
    

    
  
Comment on attachment 229827 [details] [diff] [review]
(Cv1-TK) <console.css>
[Checkin: Comment 12 and 14]

(I hadn't noticed that you merged the patches when you checked them in :-<)

        Attachment #229827 -
        Attachment description: (Cv1-TK) <console.css>
[Checkin: Comment 12] → (Cv1-TK) <console.css>
[Checkin: Comment 12 and 14]

        Attachment #229827 -
        Attachment is obsolete: true

    
    

    
  
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060723 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.
Whiteboard: [verified-seamonkey1.1a]
Product: Firefox → Toolkit

    
    

    
  
Resetting QA contact to default.
QA Contact: nobody → error.console
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: