289994 - Need REQUIRES to build canvas

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

When I --enable-cairo, I fail to build layout because of inaccessible #includes.
Patch coming up.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 180437 [details] [diff] [review]
fix

r+sr=shaver

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 180437 [details] [diff] [review]
fix

simple build config fix to make canvas build.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 180437 [details] [diff] [review]
fix

a=brendan for 1.8b2.

/be

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 6

[Boris Zbarsky [:bzbarsky]]

Hmm.... Wasn't this a duplicate of bug 279908?  And isn't the patch there
cleaner?  And possibly still needed?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, I guess that's the better fix.

I'll leave mine in for now because it does fix the build.