Closed
Bug 290172
Opened 19 years ago
Closed 19 years ago
Pressing left or right arrow key in location bar causes refresh
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
People
(Reporter: stevee, Assigned: mark)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.55 KB,
patch
|
mconnor
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050413 Firefox/1.0+ 1. Make a new profile 2. Open firefox with the new profile. 3. Wait for the google-firefox page to load 4. Place the curser in the location bar 5. Press left arrow key or right arrow key Actual: Page refreshes Expected: Caret moves in location bar, no refresh
Reporter | ||
Comment 1•19 years ago
|
||
Expected behaviour in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050411 Firefox/1.0+ (arrow key movement doesn't force a refresh)
Reporter | ||
Comment 2•19 years ago
|
||
From IRC: ajschult|zzz: stevee: the cursor moves (left or right)... with 2005041205 on linux [(suite) the page is not refreshed; expected behaviour]
WFM in build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050412 Firefox/1.0+ too
Reporter | ||
Comment 4•19 years ago
|
||
Expected behaviour in the official nightly from Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050412 Firefox/1.0+
Reporter | ||
Comment 5•19 years ago
|
||
I'd guess one of these checkins might have caused this: bug 283777 , bug 289022 or bug 289730
Reporter | ||
Updated•19 years ago
|
Summary: Pressing left or right arrowkey in location bar causes refresh → Pressing left or right arrow key in location bar causes refresh
Reporter | ||
Updated•19 years ago
|
Assignee: firefox → bugs
Component: General → Location Bar and Autocomplete
QA Contact: general → davidpjames
Comment 6•19 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050413 Firefox/1.0+ ez repro with old profile too. 1.open FF 2.open any page 3.focus in the locationbar 4.press [end] to move the cursor to the end of the line 5.press [right arrow] 6.page reloads 7.focus/cursor is no longer in the locationbar 8.focus in the locationbar 9.press [home] to move the cursor to the end of the line 10.press [left arrow] .... 11.page reloads 12.focus/cursor is no longer in the locationbar
Comment 7•19 years ago
|
||
let's try blaming bug 283777 for a start :)
Comment 8•19 years ago
|
||
This was caused by 283777, as far as I can tell. The easiest solution is probably to check for an open popup (using mInput->GetPopupOpen) before calling HandleEnter.
OS: Windows 2000 → All
Hardware: PC → All
Comment 9•19 years ago
|
||
*** Bug 290270 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
Severity: normal → major
Assignee | ||
Comment 11•19 years ago
|
||
Restores location bar to proper working order. This is a reimplementation of the changes from bug 283777 attachment 175688 [details] [diff] [review]. Rather than naïvely call HandleEnter any time a left or right arrow is pressed, only fill the text box if the popup is open and has a selected item, then close any open popup. HandleEnter doesn't work in the location bar or search bar because pressing enter in those contexts causes the browser to load the URL or perform the search.
Assignee | ||
Updated•19 years ago
|
Attachment #180740 -
Flags: review?
Attachment #180740 -
Flags: approval-aviary1.1a?
Attachment #180740 -
Flags: approval-aviary1.0.3?
Comment 12•19 years ago
|
||
Comment on attachment 180740 [details] [diff] [review] fix setting victim on review request
Attachment #180740 -
Flags: review? → review?(mconnor)
Updated•19 years ago
|
Attachment #180740 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
Comment 13•19 years ago
|
||
*** Bug 290416 has been marked as a duplicate of this bug. ***
Comment 14•19 years ago
|
||
Comment on attachment 180740 [details] [diff] [review] fix this isn't in 1.0.3, thankfully, but this should go into 1.0.4 if there is one, but we'd need a modified patch to replace what's on branch properly. If you could do that it'd be great. I'll land this shortly, thanks a lot!
Attachment #180740 -
Flags: review?(mconnor) → review+
Updated•19 years ago
|
Assignee: bugs → mark
Comment 15•19 years ago
|
||
Checking in toolkit/components/autocomplete/src/nsAutoCompleteController.cpp; /cvsroot/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.c p,v <-- nsAutoCompleteController.cpp new revision: 1.31; previous revision: 1.30 done Mark, can you port this patch to the aviary 1.0.1 branch so we can take that instead of the patch for bug 283777? If not, please let me know.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Attachment #180740 -
Flags: approval-aviary1.0.3?
Assignee | ||
Comment 16•19 years ago
|
||
Pulling the 1_0_1 tree now. Thanks, Mike.
Flags: blocking-aviary1.0.4?
Assignee | ||
Comment 17•19 years ago
|
||
Bringing this back over to bug 283777 for work on the AVIARY_1_0_1 branch. The problem patch never landed there and thus this bug doesn't apply. Attachment 180857 [details] [diff] is a port of this trunk patch to the 1.0.x branch.
Flags: blocking-aviary1.0.4?
Updated•19 years ago
|
Flags: blocking-aviary1.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•