Closed
Bug 290217
Opened 19 years ago
Closed 19 years ago
Build DBM from sources in the "gmake import" build method
Categories
(NSS :: Build, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.10
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
911 bytes,
patch
|
rrelyea
:
review+
christophe.ravel.bugs
:
superreview+
|
Details | Diff | Splinter Review |
One way to build NSS is to import its dependencies as pre-built binary components. I call this the "gmake import" build method. In NSS 3.10, we no longer build DBM as a separate component. So NSS's "gmake import" makefile rule needs to be updated to reflect this change.
Assignee | ||
Comment 1•19 years ago
|
||
1. Upgrade to NSPR 4.6. (This affects the "gmake import" build method only. You can continue to build NSS 3.10 against NSPR 4.4.1 or later if you do a full source build.) 2. Do not import DBM. 3. Need to build DBM after the "gmake import" step.
Attachment #180618 -
Flags: superreview?(christophe.ravel.bugs)
Attachment #180618 -
Flags: review?(rrelyea)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 3.10
Comment 2•19 years ago
|
||
Comment on attachment 180618 [details] [diff] [review] Proposed patch r+ if sun's ok with the change this close to 3.10 shipping.
Attachment #180618 -
Flags: review?(rrelyea) → review+
Comment 3•19 years ago
|
||
ok for me. In our build, we don't use the global "nss_RelEng_bld" target. We have: "gmake build_coreconf build_dbm all"
Assignee | ||
Comment 4•19 years ago
|
||
Christophe, how do you build NSPR? Do you use NSS's build_nspr makefile target? I checked in the patch on the trunk for NSS 3.10. Enter passphrase for key '/cygdrive/c/Documents and Settings/wtc/.ssh/id_dsa': Checking in manifest.mn; /cvsroot/mozilla/security/nss/manifest.mn,v <-- manifest.mn new revision: 1.17; previous revision: 1.16 done Checking in Makefile; /cvsroot/mozilla/security/nss/Makefile,v <-- Makefile new revision: 1.34; previous revision: 1.33 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Attachment #180618 -
Flags: superreview?(christophe.ravel.bugs) → superreview+
You need to log in
before you can comment on or make changes to this bug.
Description
•