290494 - Drag and drop (d&d) shows wrong target in trees (mail folders, bookmarks, etc.)

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Bob Clary [:bc] (inactive)]

Starting with today's (2005-04-15) build, when I attempt to drag a message from
one folder to another the highlighted folder does not track the mouse but is
offset from the mouse by approximately 7 rows.

Comment 1

[Jerry Baker]

This is a major regression that occured between 20050414 and 20050415. It seems
that there are a number of bugs in this timeframe involving mouse position. The
check-in for bug 289792 is very suspicious here.

Comment 2

[Jerry Baker]

Attachment: Screen capture illustrating the issue

Notice the mouse pointer is several rows higher than the highlighted folder.

Comment 3

[WADA:World Anti-bad-Duping Agency]

*** Bug 290629 has been marked as a duplicate of this bug. ***

Comment 4

[WADA:World Anti-bad-Duping Agency]

Same sysmtom, same regression is reported to Bug 290629 for Mozilla Application
Suite MailNews.

Comment 5

[Jerry Baker]

If it exists in both, then it is a core bug.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Bugzilla's collision detection just totally fucked up.  :(

Resetting the right summary and component.  This has nothing to do with mailnews.

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 290629 has been marked as a duplicate of this bug. ***

Comment 8

[Ian Neal]

*** Bug 290744 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

The last hunk is what's really needed to fix this bug... The rest is dealing
with the "nscoord is PRInt32" assumptions all over the code.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 180988 [details] [diff] [review]
Fix

boxobject APIs should deal with CSS pixels, so you might as well note that.

+  // XXXbz except what this is _really_ doing is assuming that the client
coords were in the inner box coord space and translating the into _our_ coord
space.	Is that really what we want here?
+  point += mInnerBox.TopLeft();

as discussed on IRC, this has always been incorrect. It should probably be
point -= mInnerBox.TopLeft().

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to comments, with d&d also fixed to handle padding

Requesting 1.8b2 approval for this regression fix

Comment 12

[Brendan Eich [:brendan]]

Comment on attachment 180992 [details] [diff] [review]
Updated to comments, with d&d also fixed to handle padding

a=brendan for 1.8b2.

/be

Comment 13

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 14

[Mike Cowperthwaite]

*** Bug 291311 has been marked as a duplicate of this bug. ***

Comment 15

[mmortal03]

A very similar issue is now occurring in Firefox bookmarks menus (not Bookmarks Manager like in this bug).  Is there a newer bug for that?  I have searched all over the place.