290988 - trunk [@ ntdll.dll + 0xeddc (0x7c90eddc) acf17ceb] Crash opening Options using non default themes - stack overflow

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Tracy Walker [:tracy]]

Seen on Windows Firefox trunk build 2005-04-19-07-trunk

-Install one of the popular themes
-Use that theme, restart.
-Go to Tools | Options

Tested results: crash everytime

Expected results:  No crash, Options dialog opens as it does with the default theme.

Talkback Incident IDs:
TB5201890E
TB5201800Z

I tested this with three different non-default themes. They all crashed when
opring the Options dialog

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050419
Firefox/1.0+ 10:44 PDT

WFM

Comment 2

[Peter van der Woude [:Peter6]]

(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050419
> Firefox/1.0+ 10:44 PDT
> 
> WFM

Oops, posted in the wrong bug, sorry

Comment 3

[timeless]

Incident ID: 5201890
Stack Signature	ntdll.dll + 0xeddc (0x7c90eddc) acf17ceb
Product ID	FirefoxTrunk
Build ID	2005041906
Trigger Time	2005-04-19 09:19:24.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	ntdll.dll + (0000eddc)
URL visited	
User Comments	crash opening options dialog with non default theme. I've tried
three different themes. all crash opening the options dialog.
Since Last Crash	36 sec
Total Uptime	1298 sec
Trigger Reason	Stack overflow
Source File, Line No.	N/A
Stack Trace 	
ntdll.dll + 0xeddc (0x7c90eddc)
msvcrt.dll + 0x1c3c9 (0x77c2c3c9)
msvcrt.dll + 0x1c3e7 (0x77c2c3e7)
msvcrt.dll + 0x19cd4 (0x77c29cd4)
nsRenderingContextWin::operator new 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/gfx/src/windows/nsFontMetricsWin.h,
line 212]
CallCreateInstance 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/xpcom/build/nsComponentManagerUtils.cpp,
line 158]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]
HandleEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsView.cpp, line
174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::Invalidate 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 3110]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1829]
nsViewManager::ProcessPendingUpdates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 1622]
nsViewManager::FlushPendingInvalidates 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/view/src/nsViewManager.cpp,
line 4324]

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The theme(s) must be invoking window transparency. That's not good. But the fact
we crash is not good either. It's bug 290102.

Comment 5

[Tracy Walker [:tracy]]

Linux Trunk Fx builds are suffering from something I believe is related to the
this bug.

-Install a popular theme (test cute and phoenity)
restart, then open Edit | Prefences

tested results:  The Prefs window appears but its content is transparent.  Only
a few widgets/text can be vaguely made out.

I saw the follow erro in the console on them installation:
*** getItemProperty failing for lack of an item. This means getResourceForItem 
              
failed to locate a resource for aItemID (item ID =
http://ftp.mozilla.org/pub/mozilla.org/themes/phoenity/phoenity-1.4.1-fx.jar,
property = disabled)

also note that with non default themes in use on Mac, the Prefs window has no
icons for the main menu items.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's worrying that these themes are invoking window transparency. We saw
something similar on one of the Tinderboxes after some packaging changes.
bsmedberg, was that resolved?

Comment 7

[Tracy Walker [:tracy]]

this bug is also present on the Thunderbird trunk

Comment 8

[Benjamin Smedberg]

The tinderbox error was because installed-chrome.txt was not registering all the
proper packages, and the default (absent any skin CSS at all, since
chrome://global/skin/ was missing) is transparent.

We should obviously fix the stack recursion (pav was working on a patch I
think), but also we should consider making a hardcoded default non-transparent
background for chrome viewport windows (in CSS-style land, perhaps?), and let
CSS override that default if they really do intend to have a transparent window.

Comment 9

[Boris Zbarsky [:bzbarsky]]

I actually can't recall whether the transparent background as default on root
window was done on purpose or not... roc, do you remember?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

When we implemented transparent windows, we decided to leave transparency as the
default. It seems logical to me, although it does surprise people sometimes.

I think changing this would be as simple as adding "window, dialog {
background:black; }" to ua.css.

Comment 11

[Chris]

not able to reproduce on windows 2000, Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.8b2) Gecko/20050419 Firefox/1.0+

Comment 12

[Tracy Walker [:tracy]]

This problem has becoem worse.  With the latest Tbird trunk build on windows
(2005-04-21-05-trunk) use a non default profile and crash on launch

Talkback ID: TB5247512W

Comment 13

[Tracy Walker [:tracy]]

*** Bug 288938 has been marked as a duplicate of this bug. ***

Comment 14

[Tracy Walker [:tracy]]

Firefox trunk from 0421 is still just crashing when opening the Options dialog
using a non-default theme.  

Should I file a seperate bug for Thunderbird?

Comment 15

[Tracy Walker [:tracy]]

Opening the help window has the same problems:
Windows: Crash
Mac: no contents
Linux: Transparent content

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is this fixed by bug 290102?

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050422
Firefox/1.0+ (built from CVS checkout at 0352 PDT 22-Apr-05)

No longer crashing with above build. Tried Qute 3, Saferfox Xpanded 2.4.2,
Phoenity 1.4.1 from UMO.

The transparency issue is now important. All three themes display the preference
categories (General, Privacy, Content ..) and the Ok & Cancel buttons on top of
the current page.

Same problem with Forumzilla preferences dialog in trunk builds of Thunderbird
(from the feed subscriptions dialog, Forumzilla 0.5.3pre4).

Comment 18

[Tracy Walker [:tracy]]

No longer crashing on windows Fx or Tbird trunk builds in the Options dialog
when using non-default themes.  Help window also has content again.

Marking fixed per comment in bug 290102.  I've also questioned whether or not
the transparency issue should have been fixed in that bug.  Let's track the
transparency issue there or in a new bug if required.

Comment 19

[Tracy Walker [:tracy]]

Filed bug 291484 for the Options dialog transparency issue.