292134 - pressing "Show Credit" causes ASSERTION

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Henrik Gemal]

if you in the about dialog presses the Credit button you get two assertions:

WARNING: Content has no document., file
e:/mozilla/mozilla/layout/generic/nsTextFrame.cpp, line 5554
WARNING: Reflow of frame failed in nsLineLayout, file
e:/mozilla/mozilla/layout/generic/nsLineLayout.cpp, line 1000
###!!! ASSERTION: reflow dirty lines failed: 'NS_SUCCEEDED(rv)', file
e:/mozilla/mozilla/layout/generic/nsBlockFrame.cpp, line 874
WARNING: Content has no document., file
e:/mozilla/mozilla/layout/generic/nsTextFrame.cpp, line 5554
WARNING: Reflow of frame failed in nsLineLayout, file
e:/mozilla/mozilla/layout/generic/nsLineLayout.cpp, line 1000
###!!! ASSERTION: reflow dirty lines failed: 'NS_SUCCEEDED(rv)', file
e:/mozilla/mozilla/layout/generic/nsBlockFrame.cpp, line 874
WARNING: Deleting out of flow without tearing down placeholder relationship,
file e:/mozilla/mozilla/layout/generic/nsFrame.cpp, line 641
WARNING: Deleting out of flow without tearing down placeholder relationship,
file e:/mozilla/mozilla/layout/generic/nsFrame.cpp, line 641
WARNING: Deleting out of flow without tearing down placeholder relationship,
file e:/mozilla/mozilla/layout/generic/nsFrame.cpp, line 641
--DOMWINDOW == 5
WARNING: getting z level of unregistered window, file
e:/mozilla/mozilla/xpfe/appshell/src/nsWindowMediator.cpp, line 635
WARNING: getting z level of unregistered window, file
e:/mozilla/mozilla/xpfe/appshell/src/nsWindowMediator.cpp, line 635
WARNING: Deleting out of flow without tearing down placeholder relationship,
file e:/mozilla/mozilla/layout/generic/nsFrame.cpp, line 641
WARNING: Deleting out of flow without tearing down placeholder relationship,
file e:/mozilla/mozilla/layout/generic/nsFrame.cpp, line 641
WARNING: Deleting out of flow without tearing down placeholder relationship,
file e:/mozilla/mozilla/layout/generic/nsFrame.cpp, line 641
WARNING: Deleting out of flow without tearing down placeholder relationship,
file e:/mozilla/mozilla/layout/generic/nsFrame.cpp, line 641
WARNING: nsTimeout::Release() proceeding without context., file
e:/mozilla/mozilla/dom/src/base/nsGlobalWindow.cpp, line 5388

Comment 1

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050428
Firefox/1.0+

FWIW, I do not get any unusual messages on opening the About Box and clicking
the 'Credit' button.

I would make these comments:

1. ###!!! ASSERTION: reflow dirty lines failed: 'NS_SUCCEEDED(rv)', ...
nsBlockFrame.cpp, line 874
2. WARNING: Deleting out of flow without tearing down placeholder relationship,
... nsFrame.cpp, line 641

I am seeing these a lot in many situations, and I assume that they are a 
consquence of some work in progress by the layout team, and is of no 
significance.

3. WARNING: Reflow of frame failed in nsLineLayout, ... nsLineLayout.cpp, line 1000

Is new to me, but I would suspect that the same applies

4. WARNING: getting z level of unregistered window, ...
src/nsWindowMediator.cpp, line 635

I see this a lot, and had assumed that it was Mac specific. Perhaps the window
for the About Box never gets registered ... I am guessing that either the
warning needs to be aware that sometimes unregistered windows can have z 
levels, or the check could be removed.

5. WARNING: nsTimeout::Release() proceeding without context., ...
nsGlobalWindow.cpp, line 5388

I see this a lot, and had assumed that it was printed whenever a timer timed
out and did not know what to do. Perhaps the warning need to be made more
specific or removed.

6. WARNING: Content has no document., ... nsTextFrame.cpp, line 5554
I have never noticed this until you mentioned it, but in fact I have been
seeing these. My guess is that the layout engine is being asked to perform
layout, but the markup has not come from a document. Unless you need to know
that this is happening, so that you can check that it is OK, it probably
means little

If any of these need patches, I would be happy to do the necessary work.
I tend to agree that unnecessary warnings can cause a needle in haystack
problem.

Comment 2

[Jesse Ruderman]

WFM.  I don't get any assertions or warnings when I click Credits in Firefox's About window.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007111415 Minefield/3.0b2pre

Comment 3

[Jesse Ruderman]

Gemal, please reopen if you still see them.