29222 - Add to addressbook and Attachment icons are not aligned

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Henrik Gemal]

If you have a mail with an attachment, an attachment icon appears. But the Add 
to adressebook and the Attachment(paperclip) icon are not correctly aligned.

Please see attached image

Comment 1

[Henrik Gemal]

Attachment: Icons not aligned

Comment 2

[Phil Peterson]

Reassign to mscott, cc jglick. Scott or Jennifer, is the problem that the icons
aren't the right size, or is this a bug in our generated XUL?

Comment 3

[jglick]

Shuang's updated icons are covered in bug#27884
and located here:
http://gooey/client/5.0/specs/visuals/icons/icon_mail/beta1/mailsmall/addtoab.gi
f
http://gooey/client/5.0/specs/visuals/icons/icon_mail/beta1/mailsmall/attachment
.gif 

Both icons are the same size, 16x16

Comment 4

[Scott MacGregor]

When we check the new icons in, this bug should go away. Since the new icons are
the same size.

So I'm going to go ahead and mark this bug a duplicate.


*** This bug has been marked as a duplicate of 27884 ***

Comment 5

[Henrik Gemal]

Still no chance the we "open sourcer" can see this icons?
When will they be moved from http://gooey to mozilla.org????

Comment 6

[lchiang]

verified as duplicate.  I'm not sure about posting these.  Jennifer?

Comment 7

[Henrik Gemal]

This bug is not about the look of the icons but about the alignment.

Comment 8

[Scott MacGregor]

Right but as I said in an earlier comment the alignment was because the icons
weren't the same size. I checked in new icons for both of these buttons that are
the same size just the other day (that was the bug that we marked this as a dup
of). So now they are aligned properly.

re-closing.

Comment 9

[Henrik Gemal]

Ok, but with the new images (build 2000040508) the alignment problem is still 
there.
Please see attached image.

Comment 10

[Henrik Gemal]

Attachment: new images still not aligned

Comment 11

[Scott MacGregor]

Wow...your eyes are better than mine. I made a style change that could fix the
problem but to be honest at normal resolutions I just can't make out the
alignment problem to figure out if I fixed it.

Can you find in your tree (release build or debug, doesn't matter), the
following file:
msgHdrViewOverlay.css

You'll see the following couple of lines:
#addToAddressBookButton {
	list-style-image:url("chrome://messenger/skin/addtoab.gif");
  min-height: 20px;
}

add the following line: margin: 0px;
So it will now look like:
#addToAddressBookButton {
  list-style-image:url("chrome://messenger/skin/addtoab.gif");
  min-height: 20px;
  margin: 0px;
}

And tell me if you can see an alignment difference? Thanks.

Comment 12

[Henrik Gemal]

Yes that fixed my alignment problem. Will you check it in?

Comment 13

[Scott MacGregor]

sure.. the tree just closed for M15 so I have to wait till it re-opens for M16.
Thanks for trying that style change out for me.

Comment 14

[Scott MacGregor]

i checked inthe style sheet change.

Comment 15

[laurel]

Looks OK in m16 builds today:
2000-04-13-10m16 commercial build linux rh6.0
2000-04-13-10m16 commercial build mac OS 9.0
2000-04-13-09m16 commercial build NT 4.0