292326 - Arrowscrollbox doesn't scroll on hover

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Martijn Wargers (dead)]

When hovering over the arrows, that gets visible when the content of the
arrowscrollbox is too large to fit in the window, the content doesn't get
scrolled anymore.

Comment 1

[Martijn Wargers (dead)]

Works with 20050428 build, fails with 20050429 build, so I think this could be a
fallout from bug 240276.

I've tested this with Firefox trunk builds (not with Mozilla builds), but I
think it also happens with Mozilla builds.

Comment 2

[Peter van der Woude [:Peter6]]

could this also cause Chatzilla randomly scrolling up ?

Comment 3

[Felix Miata]

Chatzilla starts with all output panes anchored to the top now.

Comment 4

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050429
Firefox/1.0+

this badly effects the bookmarks menu
the scroll will only happen when you click on the arrow, which means you can
just scroll 1 bookmark up/down per click
real fun if you have a row of 200 bookmarks, not

-> ?1.1 

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is a regression from jst's trusted-events checkin. The mouse-clicks
generated by the repeating timer nsAutoRepeatButtonFrame weren't trusted events
so the chrome event handlers weren't seeing them.

This patch fixes that. To avoid introducing a hole where an untrusted mouse
event could start a timer generating trusted mouse clicks, the synthetic clicks
inhert the trustedness of the triggering mouse event.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

BTW, I checked that nsAutoRepeatButtonBox is the only method that passes nsnull
in aEvent to MouseClicked, although the way I've written the code is safe even
if someone else does.

Comment 7

[Steve England [:stevee]]

*** Bug 292628 has been marked as a duplicate of this bug. ***

Comment 8

[Sébastien Auger]

can someone do the check-in ?

Comment 9

[Ger Teunis]

I noticed when I make my Firefox window smaller and open a long Arrowscrollbox
and use the arrow keys for scrolling down AND resize the firefox window to
normal size again (so the arrows will disappear) there is extra empty space on
the bottom of the Arrowscrollbox.

Reproduce:
1. Add http://www.tweakers.net/feeds/mixed.xml to your bookmark toolbar
2. Make Fx window a lot smaller (like 200x100 or so) until the Arrowscrollbox
arrows appear.
3. Click a few times on the 'down arrow'
4. Make Fx full-screen again
5. Extra empty space is displayed below "Open in tabs"

If this is not related: I would be happy to file a new bug on this.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sebastian: it needs review first.

Ger: probably not related, please file a new bug.

Comment 11

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> I noticed when I make my Firefox window smaller and open a long Arrowscrollbox
> and use the arrow keys for scrolling down AND resize the firefox window to
> normal size again (so the arrows will disappear) there is extra empty space on
> the bottom of the Arrowscrollbox.
> 
> Reproduce:
> 1. Add http://www.tweakers.net/feeds/mixed.xml to your bookmark toolbar
> 2. Make Fx window a lot smaller (like 200x100 or so) until the Arrowscrollbox
> arrows appear.
> 3. Click a few times on the 'down arrow'
> 4. Make Fx full-screen again
> 5. Extra empty space is displayed below "Open in tabs"
> 
> If this is not related: I would be happy to file a new bug on this.

bug 185054 maybe ?
You may want to attach the testcase there, better then what's in that bug

Comment 12

[Ger Teunis]

(In reply to comment #10)
> Ger: probably not related, please file a new bug.

(In reply to comment #11)
> bug 185054 maybe ?
> You may want to attach the testcase there, better then what's in that bug

Thank you, it surely looks like 185054 indeed.
Will post the testcase there.

Comment 13

[Johnny Stenback (:jst)]

Comment on attachment 182373 [details] [diff] [review]
fix

r+sr=jst, sorry for not catching this in the initial landing :(

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 182373 [details] [diff] [review]
fix

Fixes scrolling menu regression

Comment 15

[Fred Collier]

(In reply to comment #14)
> (From update of attachment 182373 [details] [diff] [review] [edit])
> Fixes scrolling menu regression
> 

Autoscroll arrows appear in the right-click context menu that aren't required.
Does your patch address this?

Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8b2) Gecko/20050504 Firefox/1.0+
05:38PDT Beast build

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 182373 [details] [diff] [review]
fix

a=asa

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Fred: this won't fix that. I don't see that problem myself. Please file a new bug.

Comment 18

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050504
Firefox/1.0+ 18:08 pdt

confirming this fixes the scrolling in bookmarks

Comment 19

[[e-mail]]

(In reply to comment #5)
>This patch fixes that. To avoid introducing a hole where an untrusted mouse
>event could start a timer generating trusted mouse clicks, the synthetic clicks
>inhert the trustedness of the triggering mouse event.
Wouldn't it have been easier not to start the timer for an untrusted mouse move?

Comment 20

[Darin Grimm]

I think this bug needs marked as fixed/Resolved.  Can someone with the proper
permissions do that?

Comment 21

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Right, thanks.

Neil: it would have been marginally easier, at the cost of disabling this
element in remote XUL apps.

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the testcase at
http://www.xulplanet.com/tutorials/xultu/examples/ex_menuscroll_1.xul with build
2005-05-16-06 on Windows XP Seamonkey trunk.

Comment 23

[Jay Patel [:jay]]

Comment on attachment 182373 [details] [diff] [review]
fix

Please check this in on the Aviary branch for 1.0.5. a=jay

Comment 24

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Dan, can you check this in for me? I don't currently have a 1.0.5 tree or watch
the tinderboxen

Comment 25

[Daniel Veditz [:dveditz]]

Incorporated into the aviary/1.7 port of bug 289940

Comment 26

[Daniel Veditz [:dveditz]]

Fix checked into mozilla1.7 and aviary1.0.1 branches