293303 - In <ABSearchDialog.js>, "Warning: redeclaration of var statusText"

Status: VERIFIED FIXED

(MailNews Core :: Address Book, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050503] (nightly) (W98SE)

{{
Warning: redeclaration of var statusText
Source File: chrome://messenger/content/ABSearchDialog.js
Line: 67, Column: 12
Source Code:
        var statusText = gAddressBookBundle.getString("matchFound");

Warning: redeclaration of var statusText
Source File: chrome://messenger/content/ABSearchDialog.js
Line: 69, Column: 12
Source Code:
        var statusText = gAddressBookBundle.getFormattedString("matchesFound",
[total]);
}}

Comes from
{{
1.12	scott%scott-macgregor.org	2004-01-27 09:32	 	Bug #132159 --> Quick Search:
Status text "1 matches found" is grammatically incorrect patch by stephen walker
r=neil sr=mscott
}}

http://lxr.mozilla.org/mozilla/source/mailnews/base/search/resources/content/ABSearchDialog.js#61
http://lxr.mozilla.org/mozilla/source/mail/base/content/ABSearchDialog.js#60

ThunderBird has the same bug !

Comment 1

[Mark Banner (:standard8)]

Fixes coming up...

Comment 2

[Mark Banner (:standard8)]

Attachment: Fix the warnings (checked in)

Simple patch to fix the warnings for both tb & sm.

Comment 3

[[e-mail]]

Comment on attachment 193205 [details] [diff] [review]
Fix the warnings (checked in)

I would just have written one really big ?:?: ;-)

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> (From update of attachment 193205 [details] [diff] [review] [edit])
> I would just have written one really big ?:?: ;-)
> 
I don't mind short ones, just long ones can be a bit too much sometimes ;-)

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 193205 [details] [diff] [review]
Fix the warnings (checked in)

Just checked in:

/cvsroot/mozilla/mailnews/base/search/resources/content/ABSearchDialog.js,v 
<--  ABSearchDialog.js
new revision: 1.19; previous revision: 1.18
done
Checking in mail/base/content/ABSearchDialog.js;
/cvsroot/mozilla/mail/base/content/ABSearchDialog.js,v	<--  ABSearchDialog.js
new revision: 1.11; previous revision: 1.10

Comment 6

[Mark Banner (:standard8)]

Attachment: Followup patch (checked in)

Follow up patch to change the if statements to a switch, requested by Neil.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 193330 [details] [diff] [review]
Followup patch (checked in)

>+      default:
>+        break;

Nit: we could do without the break in the default case(s)...

Comment 8

[[e-mail]]

IIRC Mozilla style specifies that the last case should always have a break too.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 193330 [details] [diff] [review]
Followup patch (checked in)

new revision: 1.20; previous revision: 1.19
done
Checking in mail/base/content/ABSearchDialog.js;
/cvsroot/mozilla/mail/base/content/ABSearchDialog.js,v	<--  ABSearchDialog.js
new revision: 1.12; previous revision: 1.11

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-09-10-05 on Windows XP SeaMonkey trunk with
strict JS warning enabled.