Closed
Bug 293390
Opened 19 years ago
Closed 18 years ago
layout issues on date/time picker to use system colors and clean up layout
Categories
(Calendar :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: andrew, Assigned: mostafah)
Details
Attachments
(1 file)
12.82 KB,
patch
|
vlad
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050424 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050424 Firefox/1.0+ The date/time pickers were using non-system defined colors in their css, which needs to be fixed before landing in toolkit. Some text on the time picker wasn't being centered. Reproducible: Always
Reporter | ||
Comment 1•19 years ago
|
||
should now use system defined colors for everything (well, if you say that -moz-Dialog is a system defined color). It should now fit in well with toolkit. Note: only classic skin was impacted as this is what will be used to move to toolkit. Also: some files from the datepicker cleanup can be removed out of /skin/XXX/datetimepickers/. Namely datepicker.css and timepicker.css.
Reporter | ||
Comment 2•19 years ago
|
||
ack. this also pulled my "clean up" of an if statement inside initTimeFormat. I can break that out into a separate patch if necessary. Sorry, trying to do too many things at once. -Andrew
Reporter | ||
Updated•19 years ago
|
Attachment #182970 -
Flags: first-review?(vladimir)
Comment on attachment 182970 [details] [diff] [review] fix css and some centering issues in the timepicker's xbl Looks good to me.. r=vladimir
Attachment #182970 -
Flags: first-review?(vladimir) → first-review+
I think the following "budy" specialization can be removed ("budy" appears nowhere else according to lxr, and an otherwise identical "busy" specialization appears a few lines later). .minimonth-day[budy="true"] { font-weight : bold; } You may also be interested in minimonth patches in bug 286841 and bug 264150. Setting status: confirmed (was unconfirmed)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 182970 [details] [diff] [review] fix css and some centering issues in the timepicker's xbl mvl checked in 5/10/2005. Leaving bug open for some additional cleanup work.
Updated•19 years ago
|
QA Contact: gurganbl → general
Comment 6•18 years ago
|
||
(In reply to comment #5) > (From update of attachment 182970 [details] [diff] [review] [edit]) > mvl checked in 5/10/2005. Leaving bug open for some additional cleanup work. > Andrew, can you clarify what else needs to be done for this bug to be closed?
Reporter | ||
Comment 7•18 years ago
|
||
Sorry, I should have been more specific as I don't recollect what else was being planned at that point. I don't have any pending layout issues here so unless someone else knows of something, it can be closed out. -Andrew
Comment 8•18 years ago
|
||
(In reply to comment #7) > Sorry, I should have been more specific as I don't recollect what else was > being planned at that point. I don't have any pending layout issues here so > unless someone else knows of something, it can be closed out. > -Andrew > Thanks for all your hard work. I'll go ahead and mark this fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•