293768 - Show All Bookmarks should remember that last state of the bookmark tree, and selected container

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Craig]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050509 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050509 Camino/0.8+

Show All Bookmarks should remember that last state of the bookmark tree.
Example., When I close the Show All Bookmarks tab after selecting a bookmark a
few levels deep in the bookmark tree, I should be able to go back into Show All
Bookmarks and still have the tree expanded to the last state I left it in rather
than collapsed as it currently is. It should function the same as the History
currently does.

Reproducible: Always

Steps to Reproduce:
1. Select Show All Bookmarks from the Bookmarks menu
2. Expand a few folders to 
3. Close the Show All Bookmarks tab
4. Open Show All Bookmarks again and you will see the bookmark tree is collapsed
and not in the last state that you left it.

Actual Results:  
Bookmark tree is collapsed

Expected Results:  
Remembered the state of the bookmark tree before you closed the Show All
Bookmarks tab.

Comment 1

[Mike Pinkerton (not reading bugmail)]

-> smfr

not sure if this is a dupe. should we put this on the 09 list or leave it for 1.0?

Comment 2

[Simon Fraser [no longer active]]

*** Bug 291906 has been marked as a duplicate of this bug. ***

Comment 3

[Simon Fraser [no longer active]]

*** Bug 298368 has been marked as a duplicate of this bug. ***

Comment 4

[John Bailey]

Also, when switching to bookmarks it always selects the "Bookmarks Menu" group.
 It would be nice that if you were in the "Bookmarks Bar" group that it would
remember that.  It looks like the this bug was fixed for Bookmarks Menu and
History, but NOT for Bookmarks Bar.

Comment 5

[Simon Fraser [no longer active]]

Fixed.

Comment 6

[Mike Nguyen]

I still see this bug in the 2005080108 and 205080208 builds... I select "Show
all bookmarks", it defaults to the bookmark bar group, I select another bookmark
group, hit CMD-B to go back to my web page, select "Show all bookmarks" (or
CMD-B) again, and I'm back at the "Bookmark Menu" group, though it preserve the
expanded state of sub-folders in the "Bookmark Menu" group.

Comment 7

[Simon Fraser [no longer active]]

OK, I need to remmeber the selected container too.

Comment 8

[Mike Nguyen]

*poke* Any progress? It seems like a pretty glaring error for a 1.0, though I
have no idea how easy it is to fix.

Comment 9

[Simon Fraser [no longer active]]

Fixed on trunk.