Closed
Bug 294232
Opened 19 years ago
Closed 19 years ago
Actually do searches through defined search datasources
Categories
(SeaMonkey :: Help Viewer, defect)
SeaMonkey
Help Viewer
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: jwalden+fxhelp, Assigned: jwalden+fxhelp)
References
()
Details
Attachments
(1 file)
1.13 KB,
patch
|
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
In the main content pack RDF file, you can define search datasources. These datasources don't show up in UI unless the user does a search that matches an element from within a search datasource. This functionality has been in extensions/help/resources/content/help.js since rev 1.28 from 2002-03-30. For whatever reason, however, this functionality is *not* in toolkit's help viewer, even tho the original code was copied from extensions/help. We need to add it back to ensure content pack compatibility. The patch, which looks to be just copying a few lines from Seamonkey's viewer, is coming soon...
Assignee | ||
Comment 1•19 years ago
|
||
This code is already in Seamonkey's help viewer and is being added to ensure content pack compatibility. I'm not sure why it's not already there.
Attachment #183624 -
Flags: first-review?(neil.parkwaycc.co.uk)
Comment 2•19 years ago
|
||
Comment on attachment 183624 [details] [diff] [review] Search through added search datasources Nit: Seems to me that this searches the datasources in a slightly different order to the xpfe version.
Attachment #183624 -
Flags: first-review?(neil.parkwaycc.co.uk) → first-review+
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 183624 [details] [diff] [review] Search through added search datasources (In reply to comment #2) > (From update of attachment 183624 [details] [diff] [review] [edit]) > Nit: Seems to me that this searches the datasources in a slightly > different order to the xpfe version. This was intentional, for a few reasons: 1. Additional search databases aren't otherwise displayed in UI, so presumably they're of less importance. Less important results should be out of the way of more important results. 2. Users often search for things they've already seen because they can't find them again. Normal search items are available in UI and thus fit this criterion. 3. The ordering used in the Seamonkey help viewer doesn't seem to be particularly logical anyway, so I'm not concerned about differences. (Toolkit's ordering isn't particularly logical now, either, but we can at least make a first step here.) The ordering is a cosmetic difference, however, that makes no difference in content pack compatibility and makes negligibly little difference in how the viewers work. Added search databases are something of an edge case anyway, so I'm not particularly concerned.
Attachment #183624 -
Flags: approval1.8b2?
Comment 4•19 years ago
|
||
Comment on attachment 183624 [details] [diff] [review] Search through added search datasources a=asa
Attachment #183624 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 5•19 years ago
|
||
Checked in, marking FIXED.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Toolkit → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•