Closed Bug 295114 Opened 19 years ago Closed 18 years ago

Reviewer comments in approval emails are not escaped properly

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Developer Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 348308

People

(Reporter: cameron, Assigned: morgamic)

References

Details

I'm seeing \' where there should be just '

I have a secondary interest in this bug as I'm currently having the same problem
with a news script on my website :( I should learn some more php :S
You should be able to take care of this with a stripslashes($comments) somewhere
in http://lxr.mozilla.org/update1.0/source/developers/mail_approval.php before
sending the mail.  Or maybe don't escape it in the first place
(http://lxr.mozilla.org/update1.0/source/developers/approval.php#36) except at
http://lxr.mozilla.org/update1.0/source/developers/inc_approval.php#29.
Summary: Apostrophes in approval emails have backslashes → Reviewer comments in approval emails are not escaped properly
*** Bug 303099 has been marked as a duplicate of this bug. ***
As mentioned in Bug 303099, this is also affecting > and " - which means it'll affect a bunch of other characters too I'm guessing.
Assignee: Bugzilla-alanjstrBugs → morgamic
Severity: minor → normal
AMO bugspam. Correcting QA contacts on OLD bugs (mozilla.update@update.bugs)

-> Correct QA contact (developers@add-ons.bugs)

Filtermeplzkthx
QA Contact: mozilla.update → developers
Duping to a newer bug because it has a patch.

*** This bug has been marked as a duplicate of 348308 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.