Closed
Bug 295847
Opened 19 years ago
Closed 19 years ago
aSubject has no properties during software update
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.35 KB,
patch
|
benjamin
:
review+
chofmann
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
This is a regression from the patch for bug 293583. Sometimes item is null which is how update determined if there was an update to an item. Also, since it relied on item being null there was no way to update the ui with the item that was checked. Patch coming up.
Assignee | ||
Comment 1•19 years ago
|
||
I'm going to do a bit more testing since this is more than likely too late for 1.1a
Assignee | ||
Updated•19 years ago
|
Keywords: regression
Assignee | ||
Comment 2•19 years ago
|
||
Benjamin - this is a simple fix for a regression caused by the patch for bug 293583 where the subject didn't always contain a valid item. I'd like to get this in if possible before 1.1a instead of backing out the patch for bug 293583 since that fixed the case where an extension could get installed when it was not compatible.
Attachment #184785 -
Attachment is obsolete: true
Attachment #184892 -
Flags: review?(benjamin)
Comment 3•19 years ago
|
||
Comment on attachment 184892 [details] [diff] [review] patch I'm not certain the status of 1.1a1, I will land this if appropriate.
Attachment #184892 -
Flags: review?(benjamin)
Attachment #184892 -
Flags: review+
Attachment #184892 -
Flags: approval-aviary1.1a1?
Comment 4•19 years ago
|
||
Comment on attachment 184892 [details] [diff] [review] patch a=chofmann for alpha
Attachment #184892 -
Flags: approval-aviary1.1a1? → approval-aviary1.1a1+
Comment 5•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.1
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•