296529 - From address in "Original Message" headers doesn't keep quotes when needed because of commas in name

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Rob Siklos [:robzilla]]

I have an e-mail and the From address is:
     "User, Larry" <[e-mail]>

However, when I forward this message, the double quotes are removed when the
From address is written in the --- Original Message --- section.  E.g:

  -------- Original Message --------
  Subject:      blahbalah
  Resent-Date:  Wed, 01 Jun 2005 04:09:27 -0400
  Resent-From:  <[e-mail]>
  Date:         Wed, 1 Jun 2005 04:09:27 -0400 (EDT)
  From:         User, Larry <[e-mail]>
  To:           Support <[e-mail]>


This is annoying, because if I use this address when composing a new mail (by
copying and pasting), I don't get the double-quotes, and the ',' in the real
name gives me two addresses instead of one.

Comment 1

[Mike Cowperthwaite]

Reproduced with TB 1.0+0803, Moz 1.7.11.  I agree, it should maintain the 
quotes.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug296529_fwd_quotes.patch

This fixes it for From, and other fields that happen to be a single addresses. 

Apparently http://mxr.mozilla.org/comm-central/source/mailnews/mime/public/nsIMsgHeaderParser.idl#135 preserveIntegrity doesn't actually work for a "line", just for a single address. If you have multiple comma separated addresses it still removes all the quotes

Comment 3

[Joshua Cranmer [:jcranmer]]

I'm not sure I agree with this bug. The change to unquote these headers was done pretty explicitly in bug 189928 (it's for display, not for name). If the use case of copy-paste email addresses is to blame, then arguably the real fix is to improve the compose widgets for addressing to accept copy-paste of "display-ready" email addresses instead of relying on them already being in MIME format.

[Note that part 1 of bug 842632 already takes a hefty whack at the compose addressing widgets, so it would be wise to wait until that lands before tackling anything with addressing widgets in compose]

Comment 4

[Magnus Melin [:mkmelin]]

Well, we can only improve the input of a copy-pase is the the receiver is also a tb user. In the end, I'd just show the quotes and be done with it. Fortunately that kind of addresses seem to be very rare nowadays.

Comment 5

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8337414 [details] [diff] [review]
bug296529_fwd_quotes.patch

Review of attachment 8337414 [details] [diff] [review]:
-----------------------------------------------------------------

I still disagree, but this patch is bitrotted anyways.

Comment 6

[Magnus Melin [:mkmelin]]

Especially for when you have multiple entries it sure is hard to parse without quotes. E.g.

Cc: Support <[e-mail]>, User, Larry <[e-mail]>