296597 - attempting to save a detached attachment opens it instead

Status: RESOLVED FIXED

(MailNews Core :: Attachments, defect)

Description

[Andrew Schultz]

With linux suite trunk 20050603, if I detach an attachment and then attempt to
save it (using save as from the context menu), it "opens" the attachment
instead, either in a browser window, or with the
how-do-you-want-to-handle-this-file dialog.  It should just bring up the file
picker and let me save it.

Comment 1

[[e-mail]]

It looks as if we don't really have a way to save detached attachments
[Thunderbird also displays the helper dialog for both open and save]
unless perhaps we should hand off to saveURL? What would that involve?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

saveURL basically only wants the URL (as a string, if I recall correctly). it
will then show a filepicker and save the URL.

Comment 3

[[e-mail]]

Attachment: Possible patch

Comment 4

[Ian Neal]

Comment on attachment 185362 [details] [diff] [review]
Possible patch

>Index: xpfe/communicator/resources/locale/en-US/contentAreaCommands.properties
>===================================================================
>+SaveAttachmentTtle=Save Attachment
SaveAttachmentTitle even?

Comment 5

[Andrew Schultz]

Comment on attachment 185362 [details] [diff] [review]
Possible patch

this patch works fine for me (with Ttle => Title)

Comment 6

[[e-mail]]

Attachment: Proposed patch

Comment 7

[David :Bienvenu]

Comment on attachment 185384 [details] [diff] [review]
Proposed patch

I'll take care of this for tbird

Comment 8

[Karsten Düsterloh]

Comment on attachment 185384 [details] [diff] [review]
Proposed patch

I'm not quite happy with SaveAttachmentTitle being in
contentAreaCommands.properties, while messenger.properties contains the very
same as  SaveAttachment, but anyway...

While you're at it, you might want to kill the erroneous space before the
ellipsis in <!ENTITY detachAttachmentCmd.label	  "Detach ...">
(http://lxr.mozilla.org/mozilla/search?string=detach%20...) also. ;-)

Besides, we should probably have different icons in the attachment box for
deleted and detached attachments...

Comment 9

[Karsten Düsterloh]

(In reply to comment #8)
> Besides, we should probably have different icons in the attachment box for
> deleted and detached attachments...

Thunderbird already has the former, but missis the latter also: see bug 292385.

Comment 10

[Karsten Düsterloh]

Okay, deleted does work in Mozilla, too (my build was horked there).

Comment 11

[[e-mail]]

Patch checked in.