296700 - Can't overlay the console's keyset (missing id)

Status: VERIFIED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Simon Bünzli]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050601 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050601 Firefox/1.0+

For my "Console Filter" extension, I wanted to add a new keyboard shortcut for
the JS console. Since the console's keyset is missing an id attribute, it can't
be simply overlayed. Since keys in a different keyset seem no to be recognized,
a JavaScript work-around is necessary.

Adding id="consoleKeys" to the keyset in chrome://global/content/console.xul
should fix this.

Reproducible: Always

Steps to Reproduce:
1. Create an extension which overlays chrome://global/content/console.xul with a
keyset (resp. have a look at "Console Filter").

Actual Results:  
The new keys aren't recognized (if the keyset in the overlay has an id, it is
missing, otherwise the keys can be moved to the right keyset through JavaScript).

Expected Results:  
The new keyset is correctly overlayed.

Comment 1

[Simon Bünzli]

Attachment: keyset id added

Comment 2

[Asaf Romano (gone)]

Comment on attachment 190662 [details] [diff] [review]
keyset id added

r=mano

Comment 3

[Asaf Romano (gone)]

Checked into trunk; also added an id to the commandset.

Comment 4

[Asa Dotzler [:asa]]

Time is short for 1.8b4. If this isn't landed today, it's not going to make the
train.

Comment 5

[Asaf Romano (gone)]

1.8 branch:
Checking in console.xul;
/cvsroot/mozilla/toolkit/components/console/content/console.xul,v  <--  console.xul
new revision: 1.5.10.1; previous revision: 1.5
done