297541 - Using window.open to open a window at (0,0) does not work

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[nandhp]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050522 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050522 Firefox/1.0+

When using window.open with options top=0,left=0, the window will open in a
random position on the screen. One coordinate must be >0.

Reproducible: Always

Steps to Reproduce:
1. Use provided test case to open windows at (0,0), (0,10) and (10,0).
2.
3.

Actual Results:  
See Details.

Expected Results:  
Firefox should have opened the window where it was asked to.

Comment 1

[nandhp]

Attachment: Testcase

Comment 2

[Mike Capp]

WFM Firefox 1.04 Win2k; looks to be Linux-specific.

Comment 3

[Jan Darmochwal]

I can confirm this with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2)
Gecko/20050613. Can't find a dupe.

Comment 4

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Confirmed again.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+

Comment #3 demonstrates that the bug is cross-product.

Comment 5

[Jan Darmochwal]

This is probably a GTK widget bug. Using treeOwnerAsWin->SetPositionAndSize()
instead of treeOwnerAsWin->SetPosition() in
nsWindowWatcher::SizeOpenedDocShellItem in file
embedding/components/windowwatcher/src/nsWindowWatcher.cpp seems to fix this.

Comment 6

[Andrew Schultz]

this is gtk2-only and regressed between linux suite trunk 2005051801 and
2005052002, probably bug 292657.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix?

I can't reproduce this in my build, but it could be my window manager or
something else. I think I see what the problem is. Can someone try this patch?

Comment 8

[Jan Darmochwal]

(In reply to comment #7)
> Can someone try this patch?

WFM with that patch.

Comment 9

[Boris Zbarsky [:bzbarsky]]

pav, if you're not going to do this review, could you move the request to
someone who will?

Comment 10

[Stuart Parmenter]

Comment on attachment 186289 [details] [diff] [review]
fix?

sure

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm not going to try for branch at this point. I'll land it on the trunk.

Comment 12

[Boris Zbarsky [:bzbarsky]]

I wend ahead and checked this in on the trunk...

Comment 13

[Christian Persch (GNOME) (away; not receiving bug mail)]

Since this checkin, I'm getting many warnings when using firefox (just moving a window and then cliking in it is enough; also on initial window show):

WARNING: BOGUS code reached!, file /opt/source/mozilla/trunk-ff/mozilla/widget/src/gtk2/nsWindow.cpp, line 591

Comment 14

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Can you add some representative stacks leading to that warning?  That'll probably help narrow it down quickly.

Comment 15

[Andrew Schultz]

Attachment: stack for bogus warning

stack from startup.  I get the warning 6x during startup and 6x (sometimes) when I move a window.  The stacks from the warnings are indistinguishable.