297660 - No node is selected anymore after deleting node in dom inspector

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Martijn Wargers (dead)]

When deleting a node in the dom inspector, I would expect that the next
available node would be selected.
Now, when I want to remove a whole row of nodes, I have to manually select
afterwards I have deleted a node with the dom inspector.

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

Well, this makes the dom inspector behave like I want it to.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 186206 [details] [diff] [review]
patch

Looks reasonable!  I won't be able to check in until July, but let me know if
this still needs checkin at that point?

Comment 3

[[e-mail]]

Comment on attachment 186206 [details] [diff] [review]
patch

>+      var selectNode = this.nextSibling;
>+      if (!selectNode) selectNode = node.previousSibling;
>+      if (!selectNode) selectNode = this.parentNode;
Nit: since JS's || operator works like Perl's, you can use e.g.
node.nextSibling || node.previousSibling || node.parentNode

Comment 4

[Martijn Wargers (dead)]

Attachment: patchv2

Thanks Neil. Does this patch need to go through the whole review process again?

Comment 5

[Martijn Wargers (dead)]

Neil, could you check patchv2 in? I don't think it needs to go to the whole
review process again, does it? Thanks.

Comment 6

[[e-mail]]

Sorry, somebody already checked in patch v1.

Comment 7

[Martijn Wargers (dead)]

Ah, ok, thanks. I see that timeless checked it in.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=dom.js&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=all&mindate=&maxdate=&cvsroot=%2Fcvsroot
Ok, this is fixed then.
That "node.nextSibling || node.previousSibling || node.parentNode" would be
nice, but is not that important.