297667 - Tasklist colors should reflect Calendar ownership

Status: NEW

(Calendar :: Tasks, enhancement)

Description

[rabbitambulance]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

IMHO, like with Events in the Calendar view, tasks in the tasklists should be
coloured according to which calendar they belong to. This could be done in the
background, so that the current colorcoding of the text could still be used.

Reproducible: Always

Steps to Reproduce:
1. Create a new Event
2. Choose a calendar other than the standard "My Calendar", for example
"yellowcal", whose colour is yellow

Actual Results:  
Event is written in grey (or maybe blue) on a white background

Expected Results:  
Event is written in grey on a yellow background.

Comment 1

[Joey Minta]

Possibly a more specific case of bug 292264.  Either way, the discussion there 
still has some relevance to this request.  As I said there, I think this 
request would create some color clashes if other changes weren't made as well.  
For instance, right now, overdue tasks have red text.  If the calendar's color 
was also red, this would create a problem.

Comment 2

[Joey Minta]

*** Bug 331903 has been marked as a duplicate of this bug. ***

Comment 3

[Stefan Sitter [:ssitter]]

I think coloring the row background based on the calendar color in not a good solution. Reason is that this makes the text hard to read for several color combination. It's also very distracting if you have a lot of different colored rows displayed. For the very same reasons we decided to not do this for the Calendar tab.

Instead I would think that adding a small colored box that indicates the calendar (similar how it was solved in the Calendar tab) might be better. This would also be in compliance with the proposal from [http://wiki.mozilla.org/Calendar:Improving_the_Calendar_Views].

Comment 5

[Bas van den Bosch]

+1 for comment 3. Of course, when this is solved it should be fairly easy to do this in userchrome.css for the entire box if people want this. 

Comment 7

[d2_c2]

I notice an add-on for 0.9pre, but this should be native to the application as
it is for the agenda pane.

Also, An added feature would allow the visibility of calendars on the today
pane to be independently selected.  Show agenda from all, but only tasks from a
select number or vice verse.  This should also be able to be selected from the today view instead of having to go to the calendar view to select calendars.

Comment 8

[Pete Riley]

(In reply to comment #7)
> [...] allow the visibility of calendars on the today
> pane to be independently selected.

probably bug 412800

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The addon in question is:

https://addons.mozilla.org/sunbird/addon/8774

I probably don't use tasks enough to judge if this is really something we should put into core code, but I agree to comment 3 too.

I could imagine an optional column similar to the calendar list that contains the color of the calendar. I'll put this into the next version of the mentioned addon.

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This patch should take care by adding an extra column that contains a field with the task color. I've also taken the liberty to generalize some code allowing treecolumns to contain the color of a calendar in any tree with minimal code adjustments.

This is a post-0.9 patch since it adds a string.

The alternative would be to make the "Calendar Name" column automatically turn into a column that shows the calendar color if it is resized to something small (i.e as soon as the column becomes square). The downside is that this behavior is not totally intuitive, the upside is that we could possibly take it for 0.9.

Christian, do you prefer the alternative, or is the currently proposed behavior better?

Comment 11

[Berend Cornelius]

Attachment: unbitrotted patch

I wanted to show Christian this patch and unbitrotted it. Maybe Philipp can have a look beforehand if everything is as it should be. I changed the order of the calendar-color with the calendar-name. Also I noticed that the there is not enough space (width) for the column header of the calendar-color column. Shall we provide a tooltip?

Comment 12

[Christian Jansen]

The default order should be as follows:

[ ] Done, [ ] Calendar, Title, [!] Priority

I've change the rows, because it would look too complex with:

[ ] Done, [ ] Calendar, [!] Priority, Title

IMO the Calendar Name row can be removed. Provides the same information like the new "Calendar" row. The name of the Calendar can be displayed as a tool tip while hovering over a calendar color box. BTW. it would be great if the box could look like the calendar boxes located in the Agenda List.

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 338308 [details] [diff] [review]
Fix - v1

I'll take care of this later, I'd like to fix a different bug first that conflicts with this one.

Comment 14

[Pander]

Hi all, any progress on this one?