297826 - Create .map files for security DLLs

Status: VERIFIED FIXED

(NSS :: Build, defect)

Description

[Peter Weilbacher]

For some tests on profiling on OS/2 I needed .map files for all DLLs (to further
create .sym files from them). The ones from security/ are linked without -Zmap
while all others seem to be linked with that, so it would be nice to add that
parameter to the GCC setup for OS/2.

Comment 1

[Peter Weilbacher]

Hups, didn't want to CC you but Julien Pierre...

Comment 2

[Peter Weilbacher]

Attachment: add -Zmap

This seems to be the right place to add the parameter.

Comment 3

[Julien Pierre]

What is the effect of -Zmap . Does it have any effect on performance ? Do you
want too do it for both optimized and debug builds ? And should it be set only
in DSO_LDOPTS for shared libraries, or also in LDFLAGS for the NSS command-line
executables ? You can build the command-line tools by doing a gmake
nss_build_all in mozilla/security/nss .

Comment 4

[Peter Weilbacher]

It just produces a .map file for the corresponding .dll (or .exe) that is linked
in the directory that it is produced in. This is mainly for finding out
addresses from crash screens (POPUPLOG.OS2) but as it contains the offset of
each function within the DLL it can in principle also be used for profiling. It
does not affect the .dll itself in any way.

I don't need it for the .exe tools but it doesn't do any harm (perhaps just
takes a second more for compilation).

It is not installed into the bin/ directory so it has no effect on download size.

Comment 5

[Wan-Teh Chang]

Mike, could you look at this patch?

Comment 6

[Wan-Teh Chang]

Comment on attachment 186389 [details] [diff] [review]
add -Zmap

This patch is fine by me.  I found that both NSPR and
the Directory C SDK use -Zmap, but Mozilla itself doesn't.
I don't know why the discrepancy.

Comment 7

[Peter Weilbacher]

Mozilla itself does, too. For the current GCC build environment it is added to
LDFLAGS in configure.in (currently line 1727).

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 186389 [details] [diff] [review]
add -Zmap

sr=mkaply

Comment 9

[Wan-Teh Chang]

Peter: I didn't know that Mozilla uses $(LDFLAGS) when building
a DLL/shared library.  Thanks for correcting me.

Comment 10

[Wan-Teh Chang]

Just curious: why don't we need to set CC (the C compiler)
in mozilla/security/coreconf/OS2.mk?  Is the default value
"cc" good for both GCC and Visual Age?

Comment 11

[Julien Pierre]

Wan-Teh, "cc" is good for neither compiler one OS/2, it's either gcc or icc
AFAIK. It must be getting set somewhere else.

Comment 12

[Peter Weilbacher]

Comment on attachment 186389 [details] [diff] [review]
add -Zmap

This is just a convenience for certain development, OS/2 only, has no effect on
code generation and shipped binaries, so it's very low risk.

Comment 13

[Wan-Teh Chang]

Patch checked in on the NSS trunk for NSS 3.10.1.

Checking in OS2.mk;
/cvsroot/mozilla/security/coreconf/OS2.mk,v  <--  OS2.mk
new revision: 1.21; previous revision: 1.20
done

Comment 14

[chris hofmann]

Comment on attachment 186389 [details] [diff] [review]
add -Zmap

a=chofmann

Comment 15

[Peter Weilbacher]

Julien or Mike, could you also check this into the normal Mozilla trunk?