29807 - JavaScript error from charsetOverlay.js on startup

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Simon Fraser [no longer active]]

I get this error every time I start up:

JavaScript Error: TypeError: contentArea has no properties
URL: chrome://global/content/charsetOverlay.js
LineNo: 106

Comment 1

[cata]

I don't see this on WinNT. Is it a mac-only bug? CC'ing Hyatt.

Comment 2

[Simon Fraser [no longer active]]

This bug is now much more apparent (and will show up in optimized builds) now 
that JS errors cause an alert to be displayed to the user.

Comment 3

[cata]

*** Bug 30812 has been marked as a duplicate of this bug. ***

Comment 4

[Frank Tang]

cata- please mark this as ASSIGN. 
pinkerton- is that true we create one more appcore to hold the "application menu 
bar" on Mac? When I help cata to trace this problem, we see the 
charsetOverlay.js get load twice when it bring up the first window. Only the 
first loading have this problem. Then, if I open a new window, it will load 
charsetOverlay.js once but not twice. This make me guess that we load the 
charsetOverlay.js for the menu bar on the startup for the application menu which 
do not have the 'appcontent'. If that is the case, maybe we should add 
change 106 from 
contentArea.addEventListener("load", charsetLoadListener, true);
to 
if(contentArea)
   contentArea.addEventListener("load", charsetLoadListener, true);

Comment 5

[Mike Pinkerton (not reading bugmail)]

i'm unfamiliar with the issues involved. cc'ing saari who might know.

Comment 6

[Simon Fraser [no longer active]]

Another easy kill. The error comes from hiddenWindow.xul, which has no element 
with id="appconent". This diff should fix it:

Index: charsetOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/charsetOverlay.js,v
retrieving revision 1.5
diff -w -c -1 -r1.5 charsetOverlay.js
*** charsetOverlay.js	2000/02/23 00:00:26	1.5
--- charsetOverlay.js	2000/03/14 19:31:19
***************
*** 104,106 ****
  
! contentArea = window.document.getElementById("appcontent")
  contentArea.addEventListener("load", charsetLoadListener, true);
--- 104,107 ----
  
! contentArea = window.document.getElementById("appcontent");
! if (contentArea)
    contentArea.addEventListener("load", charsetLoadListener, true);

Comment 7

[Simon Fraser [no longer active]]

I checked in the above diff.

Comment 8

[Simon Fraser [no longer active]]

Fixed

Comment 9

[Teruko Kobayashi]

Verified.