298432 - crash at startup due to nsIPrefBranchInternal

Status: VERIFIED INVALID

(Core :: Preferences: Backend, defect)

Description

[Henrik Gemal]

I had the following in an extension:
var pbi  =
Components.classes["@mozilla.org/preferences-service;1"].createInstance(Components.interfaces.nsIPrefBranchInternal);

and my firefox crash'es at startup

Talkback:
TB6881626K
TB6881619Y

Comment 1

[Dave Townsend [:mossop]]

Shouldn't you be using getService for the prefs service?

Comment 2

[timeless]

precisely. although the prefservice really shouldn't suck this way either.

Comment 3

[Henrik Gemal]

from
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB6881626K

it says it crashes in
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/modules/libpref/src/prefapi.cpp&mark=862&rev=#862

Comment 4

[timeless]

that sounds familiar, we've had crashes in that mess before.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'm going to mark this invalid, sorry.  It's a service.  Don't createInstance it.

Comment 6

[Henrik Gemal]

when I add this line to a extension of mine
var pbi  =
Components.classes["@mozilla.org/preferences-service;1"].createInstance(Components.interfaces.nsIPrefBranchInternal);

my browser become non functional and I got some weird alerts with:
"You cannot connect to bugzilla.mozilla.org because SSL is disabled."

weird

Comment 7

[Boris Zbarsky [:bzbarsky]]

The point is, you're using createInstance.  DON'T DO THAT.

Comment 8

[Henrik Gemal]

(In reply to comment #7)
> The point is, you're using createInstance.  DON'T DO THAT.
> 

yes yes. I know that...