29845 - Support disk space verification in Mac/Unix .xpis

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Samir Gehani]

Implement a aily upadted key like $Version$ indicating space required for the 
component being installed (say $SpaceRequired$).  Also, the install.js 
templates need to be updated to perform disk space verification before 
installing.

Comment 1

[Cathleen]

we need to do diskspace checking before install.

Comment 2

[Cathleen]

*** Bug 32516 has been marked as a duplicate of this bug. ***

Comment 3

[Jimmy Lee]

Adding myself to Cc.

Comment 4

[leger]

Putting on [nsbeta2+] radar for beta2 fix.

Comment 5

[Daniel Veditz [:dveditz]]

This fix is hanging too far off the end, asking that this be chopped for 
nsbeta2.  The Mac is OK without this fix because the install wizard itself does 
some rudimentary space checking, though it may hurt the Netcenter SmartUpdate 
site for some people. Try again in nsbeta3

Comment 6

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 7

[Samir Gehani]

JJ will be adding $SpaceRequired$ parsing into the Mac build scripts that 
generate the .jsts next week sometime.  Once that is online, we merely need to 
modify the .jsts to check for diskspace.  

The Unix equivalent will be handled in deliver.pl.

Comment 8

[J.J. Enser]

mac done. you can edit the .jst files anytime and the Mac automation will pick it 
up.
Note that the size is currently inserted in Kbytes.

Comment 9

[Samir Gehani]

Thanks JJ!

Comment 10

[Samir Gehani]

Fixes checked in for {moz,ns} x {mac,linux} .jst files.

Comment 11

[Grace Bush]

On a nearly full disk on the Mac, I am able to go through installation process- 
with some oddities, but no warnings. 
After 'Installing XPCOM'- I see processing file 14 of 14 for a very long time 
while 'Installing Navigator' and 'Installing Mail/News' is displayed.  I do not 
see the usual processing or installing of files 1-24xx for Navigator. It 
installs Instant Messenger- but bottom line is no launch, no executable files, 
no icon

With this fix, I expected to see 'disk space full' warning- is that correct?

Comment 12

[Samir Gehani]

No, with this fix, if you update from teh browser (like using update.html) and 
you don't have enough space you should see INSUFFICIENT_DISK_SPACE (rather it's 
numeric error code equivalent) logged in the install log.

Comment 13

[Grace Bush]

Got it, verified using update.html - received error -235 INSUFFICIENT DISK SPACE