Closed
Bug 298462
Opened 19 years ago
Closed 19 years ago
GC old code?
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.6.1
People
(Reporter: pw-fb, Assigned: wtc)
Details
Attachments
(1 file)
|
884 bytes,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.8b2) Gecko/20050620 Firefox/1.0+ Build Identifier: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.8b2) Gecko/20050620 Firefox/1.0+ From the root of the mozilla source (20 June CVS) % find . -printx | xargs grep -Hn _PRSockOptVal_t ./nsprpub/pr/src/pthreads/ptio.c:203:#define _PRSockOptVal_t char * ./nsprpub/pr/src/pthreads/ptio.c:208:#define _PRSockOptVal_t void * % so one more instance of #if defined(NetBSD) can go (patch about to be included..) Reproducible: Always
|
Reporter | |
Comment 1•19 years ago
|
||
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 187024 [details] [diff] [review] as mentioned in original report r=wtc. I verified that the _PRSockOptVal_t type is defined but not used.
Attachment #187024 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Patch checked in on the NSPR trunk for NSPR 4.6.1. Thanks a lot for the patch. Checking in ptio.c; /cvsroot/mozilla/nsprpub/pr/src/pthreads/ptio.c,v <-- ptio.c new revision: 3.100; previous revision: 3.99 done
Severity: normal → trivial
Status: UNCONFIRMED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.6.1
You need to log in
before you can comment on or make changes to this bug.
Description
•