298489 - venkman lose breakpoints position

Status: RESOLVED INCOMPLETE

(Other Applications Graveyard :: Venkman JS Debugger, enhancement)

Description

[Mathieu Jobin]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

when the code change, the breakpoints keep is line number not the actual line of
code, so when you add/remove a line, the bookmark move. (or the code move
underneith it)



Reproducible: Always

Steps to Reproduce:
1. use the JS debugger
2. set a breakpoint
3. use it some more ;)
4. add or remove a line of code in your JS
5. refresh the page
6. use the JS Debugger again, BP is wrong.

Comment 1

[James Ross]

-> All/All
-> Enhancement (current behaviour matches other debuggers)

I'm not even sure this is possible, at the general level. The JS engine sure
doesn't know what you changed. Could start by checking the code for the line, if
it has changed, go looking for it within a +/- 10 line range or something. If
not found, leave line alone and disable BP. Not sure what should happen if
multiple matches are found (use closest? what about two at equal distance?).

Comment 2

[Mathieu Jobin]

equal distance in different functions, any of the two functions is more corrent ?
equal distance in the same function ? euh .... ? 

i don't know... seriously I don't remember any debugger I use that was not
remembering the line position properly. maybe I'm wrong,... I had to check again.

but I think both kdbg and Visual Studio and even Borland C, did remember the
code I put a breakpoint on, as I stated, not only the line number.

but its possible that I miss-remember.

Comment 3

[James Ross]

Delphi (my main IDE/language) does it, but like Visual Studio they have the
advantage of BEING the editor. That makes it pathetically easy for them. :)

I was refering to windbg in my earlier comment, and I'm pretty sure it doesn't
move them - and it is the closest native thing to how JSD works (i.e. it just
sits and watches, it doesn't actually have any part in the source itself).

Comment 4

[Mathieu Jobin]

make sens, I'll try kdbg tonight see if it does it or not.

kdbg is a kdelibs written frontend to unix gdb

Comment 5

[Mathieu Jobin]

you are right....  
  
kdbg does not do it either...  
  
Delphi and al. use their big advantage of being the editor, as you said...  
  
its sad,.. anyway... It would still be a very nice enhancement.  
  
just an idea to add to your previous thought. if you got to choose between two  
lines,... maybe you can popup a message and set both of those lines.  
  
anyway, thanks for the excellent debugger.  
  
  

Comment 6

[BMO Automation]

Component is obsolete so resolving bugs as INCOMPLETE